From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Frederic Weisbecker <fweisbec@gmail.com>,
Matt Fleming <matt@console-pimps.org>
Subject: [PATCH 3/4] ftrace: Fix the conditional that updates $ref_func
Date: Thu, 23 Jul 2009 17:00:50 -0400 [thread overview]
Message-ID: <20090723210220.680604358@goodmis.org> (raw)
In-Reply-To: 20090723210047.294710482@goodmis.org
[-- Attachment #1: 0003-ftrace-Fix-the-conditional-that-updates-ref_func.patch --]
[-- Type: text/plain, Size: 1016 bytes --]
From: Matt Fleming <matt@console-pimps.org>
Fix the conditional that checks if we already have a $ref_func and that
the new function is weak. The code as previously checking whether either
condition was false, and we really need to only update $ref_func is both
cconditions are false.
Signed-off-by: Matt Fleming <matt@console-pimps.org>
LKML-Reference: <1248365775-25196-1-git-send-email-matt@console-pimps.org>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
scripts/recordmcount.pl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl
index 7109e2b..16c5563 100755
--- a/scripts/recordmcount.pl
+++ b/scripts/recordmcount.pl
@@ -414,7 +414,7 @@ while (<IN>) {
$read_function = 0;
} else {
# if we already have a function, and this is weak, skip it
- if (!defined($ref_func) || !defined($weak{$text})) {
+ if (!defined($ref_func) && !defined($weak{$text})) {
$ref_func = $text;
}
}
--
1.6.3.3
--
next prev parent reply other threads:[~2009-07-23 21:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-23 21:00 [PATCH 0/4] [GIT PULL][2.6.31] tracing: more fixes Steven Rostedt
2009-07-23 21:00 ` [PATCH 1/4] tracing: show proper address for trace-printk format Steven Rostedt
2009-07-23 21:00 ` [PATCH 2/4] tracing: only truncate ftrace files when O_TRUNC is set Steven Rostedt
2009-07-23 21:00 ` Steven Rostedt [this message]
2009-07-23 21:00 ` [PATCH 4/4] ftrace: Only update $offset when we update $ref_func Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090723210220.680604358@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox