public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Frans Pop <elendil@planet.nl>
To: Alan Cox <alan@linux.intel.com>
Cc: Erik Ekman <erik@kryo.se>,
	linux-kernel@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [PATCH -tip][RFC] serial8250: update to dev_pm_ops
Date: Sat, 25 Jul 2009 22:22:26 +0200	[thread overview]
Message-ID: <200907252222.28189.elendil@planet.nl> (raw)
In-Reply-To: <200907251612.34140.elendil@planet.nl>

On Saturday 25 July 2009, Frans Pop wrote:
> On Wednesday 08 July 2009, Alan Cox wrote:
> > On Wed, 8 Jul 2009 Frans Pop <elendil@planet.nl> wrote:
> > > > From dmesg:
> > > > Platform driver 'serial8250' needs updating - please use
> > > > dev_pm_ops
> > > >
> > > > Is this how it should be done?
> > >
> > > Alan or Rafael can probably tell.
> >
> > No idea. I've not looked at this so your guess is as good as mine
> > (but looks quite believable. I don't plan to do anything until
> > someone who needs platform 8250 support sends a tested version of the
> > change however.
>
> I have done a few of these myself now and followed all other similar
> updates for other drivers. From that experience I can say that this
> update is both trivial and correct. Hope you will reconsider your
> reluctance on that basis.

Please cancel that. It turns out that the old system also supported 
suspend to disk, which most driver conversions so far did not allow for.

Kudo's to Dmitry Torokhov for bringing this up.

Sorry.

      parent reply	other threads:[~2009-07-25 20:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-01  6:37 [PATCH -tip][RFC] serial8250: update to dev_pm_ops Erik Ekman
2009-07-08 11:10 ` Frans Pop
2009-07-08 13:43   ` Alan Cox
2009-07-25 14:12     ` Frans Pop
2009-07-25 20:18       ` Rafael J. Wysocki
2009-07-25 20:59         ` [PATCH v2 " Erik Ekman
2009-07-26  0:52           ` Dmitry Torokhov
2009-07-26 19:45             ` Rafael J. Wysocki
2009-07-26 20:52               ` Frans Pop
2009-07-26 22:38                 ` Rafael J. Wysocki
2009-07-27  2:57                 ` Magnus Damm
2009-08-03 10:42                   ` Erik Ekman
2009-07-25 20:22       ` Frans Pop [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907252222.28189.elendil@planet.nl \
    --to=elendil@planet.nl \
    --cc=alan@linux.intel.com \
    --cc=erik@kryo.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox