Re: [PATCH] libata: remove superfluous NULL pointer checks

Jeff Garzik
2009-07-29T01:10:29Z

Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] libata: remove superfluous NULL pointer checks
>
> host->ports[] always contain pointers to valid port structures since
> a "dummy port" structure is used in case if there is no physical port.
>
> This patch takes care of two entries from Dan's list:
>
> drivers/ata/sata_sil.c +535 sil_interrupt(13) warning: variable derefenced before check 'ap'
> drivers/ata/sata_mv.c +2517 mv_unexpected_intr(6) warning: variable derefenced before check 'ap'
>
> and of another needless NULL pointer check in pata_octeon_cf.c.
>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Cc: corbet@lwn.net
> Cc: eteo@redhat.com
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---
> drivers/ata/pata_octeon_cf.c | 3 ++-
> drivers/ata/sata_mv.c | 2 +-
> drivers/ata/sata_sil.c | 2 +-
> 3 files changed, 4 insertions(+), 3 deletions(-)

applied to #upstream-fixes