Re: [PATCH v2] Remove Spurious PnP Memory Reserved Warning

[Jesse Barnes <jbarnes@virtuousgeek.org>]

On Tue, 28 Jul 2009 09:36:23 +0530
David John <davidjon@xenontk.org> wrote:

> Remove unnecessary complaints by the PnP sub-system about memory
> ranges being reserved.
> 
> Signed-off-by: David John <davidjon@xenontk.org>
> 
> diff --git a/drivers/pnp/system.c b/drivers/pnp/system.c
> index 59b9092..84ee297 100644
> --- a/drivers/pnp/system.c
> +++ b/drivers/pnp/system.c
> @@ -48,10 +48,11 @@ static void reserve_range(struct pnp_dev *dev,
> resource_size_t start,
>  	 * example do reserve stuff they know about too, so we may
> well
>  	 * have double reservations.
>  	 */
> -	dev_info(&dev->dev, "%s range 0x%llx-0x%llx %s reserved\n",
> -		port ? "ioport" : "iomem",
> -		(unsigned long long) start, (unsigned long long) end,
> -		res ? "has been" : "could not be");
> +	if (res) {
> +		dev_info(&dev->dev, "%s range 0x%llx-0x%llx has been
> "
> +			 "reserved\n",	port ? "ioport" :
> "iomem",
> +			(unsigned long long) start, (unsigned long
> long) end);
> +	}
>  }
>  
>  static void reserve_resources_of_dev(struct pnp_dev *dev)

I'm inclined to keep the message, since it's just a dev_info and does
provide interesting info sometimes.  So unless Linus wants to kill
it...

Jesse

-- 
Jesse Barnes, Intel Open Source Technology Center