[PATCH] driver core: simplify platform_get_resource()

Mike Frysinger
2009-07-27T18:20:58Z

The platform_get_resource() function takes a number for the desired index
into the resource array, but then does a for loop on the array to get to
that index. Considering the array is linear, the loop overhead is just
that -- overhead. So unless I missed something, convert it into an index
check and access the desired resource directly. Resulting code makes a
lot more sense considering its purpose.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
drivers/base/platform.c | 10 ++++------
1 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/base/platform.c b/drivers/base/platform.c
index 81cb01b..dc8c943 100644
--- a/drivers/base/platform.c
+++ b/drivers/base/platform.c
@@ -37,14 +37,12 @@ EXPORT_SYMBOL_GPL(platform_bus);
struct resource *platform_get_resource(struct platform_device *dev,
unsigned int type, unsigned int num)
{
- int i;
-
- for (i = 0; i < dev->num_resources; i++) {
- struct resource *r = &dev->resource[i];
-
- if (type == resource_type(r) && num-- == 0)
+ if (num >= 0 && num < dev->num_resources) {
+ struct resource *r = &dev->resource[num];
+ if (type == resource_type(r))
return r;
}
+
return NULL;
}
EXPORT_SYMBOL_GPL(platform_get_resource);
--
1.6.3.3