* [PATCH] Deny CLONE_PARENT|CLONE_NEWPID combination
@ 2009-07-28 16:44 Sukadev Bhattiprolu
2009-07-28 18:05 ` Serge E. Hallyn
0 siblings, 1 reply; 3+ messages in thread
From: Sukadev Bhattiprolu @ 2009-07-28 16:44 UTC (permalink / raw)
To: Andrew Morton
Cc: oleg, roland, Eric W. Biederman, Oren Laadan, serue,
Alexey Dobriyan, Containers, linux-kernel
Deny CLONE_PARENT|CLONE_NEWPID combination.
CLONE_PARENT was used to implement an older threading model. For consistency
with the CLONE_THREAD check in copy_pid_ns(), disable CLONE_PARENT and
CLONE_SIGHAND with CLONE_NEWPID, at least until the required semantics of
the pid namespaces are clear.
Changelog[v3]:
Remove CLONE_SIGHAND and for now only fail CLONE_NEWPID|CLONE_PARENT.
Changelog[v2]:
[Eric Biederman] Disable CLONE_SIGHAND also ?
Signed-off-by: Sukadev Bhattiprolu <sukadev@us.ibm.com>
Acked-by: Roland McGrath <roland@redhat.com>
Acked-by: Serge Hallyn <serue@us.ibm.com>
---
kernel/pid_namespace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-mmotm/kernel/pid_namespace.c
===================================================================
--- linux-mmotm.orig/kernel/pid_namespace.c 2009-07-16 10:03:01.000000000 -0700
+++ linux-mmotm/kernel/pid_namespace.c 2009-07-16 11:37:24.000000000 -0700
@@ -118,7 +118,7 @@
{
if (!(flags & CLONE_NEWPID))
return get_pid_ns(old_ns);
- if (flags & CLONE_THREAD)
+ if (flags & (CLONE_THREAD|CLONE_PARENT))
return ERR_PTR(-EINVAL);
return create_pid_namespace(old_ns);
}
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Deny CLONE_PARENT|CLONE_NEWPID combination
2009-07-28 16:44 [PATCH] Deny CLONE_PARENT|CLONE_NEWPID combination Sukadev Bhattiprolu
@ 2009-07-28 18:05 ` Serge E. Hallyn
2009-07-28 19:06 ` Sukadev Bhattiprolu
0 siblings, 1 reply; 3+ messages in thread
From: Serge E. Hallyn @ 2009-07-28 18:05 UTC (permalink / raw)
To: Sukadev Bhattiprolu
Cc: Andrew Morton, oleg, roland, Eric W. Biederman, Oren Laadan,
Alexey Dobriyan, Containers, linux-kernel
Quoting Sukadev Bhattiprolu (sukadev@linux.vnet.ibm.com):
>
> Deny CLONE_PARENT|CLONE_NEWPID combination.
>
> CLONE_PARENT was used to implement an older threading model. For consistency
> with the CLONE_THREAD check in copy_pid_ns(), disable CLONE_PARENT and
> CLONE_SIGHAND with CLONE_NEWPID, at least until the required semantics of
> the pid namespaces are clear.
>
> Changelog[v3]:
> Remove CLONE_SIGHAND and for now only fail CLONE_NEWPID|CLONE_PARENT.
(FWIW your patch description does not reflect this...)
> Changelog[v2]:
> [Eric Biederman] Disable CLONE_SIGHAND also ?
>
> Signed-off-by: Sukadev Bhattiprolu <sukadev@us.ibm.com>
> Acked-by: Roland McGrath <roland@redhat.com>
> Acked-by: Serge Hallyn <serue@us.ibm.com>
> ---
> kernel/pid_namespace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-mmotm/kernel/pid_namespace.c
> ===================================================================
> --- linux-mmotm.orig/kernel/pid_namespace.c 2009-07-16 10:03:01.000000000 -0700
> +++ linux-mmotm/kernel/pid_namespace.c 2009-07-16 11:37:24.000000000 -0700
> @@ -118,7 +118,7 @@
> {
> if (!(flags & CLONE_NEWPID))
> return get_pid_ns(old_ns);
> - if (flags & CLONE_THREAD)
> + if (flags & (CLONE_THREAD|CLONE_PARENT))
> return ERR_PTR(-EINVAL);
> return create_pid_namespace(old_ns);
> }
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Deny CLONE_PARENT|CLONE_NEWPID combination
2009-07-28 18:05 ` Serge E. Hallyn
@ 2009-07-28 19:06 ` Sukadev Bhattiprolu
0 siblings, 0 replies; 3+ messages in thread
From: Sukadev Bhattiprolu @ 2009-07-28 19:06 UTC (permalink / raw)
To: Serge E. Hallyn
Cc: Andrew Morton, oleg, roland, Eric W. Biederman, Oren Laadan,
Alexey Dobriyan, Containers, linux-kernel
Serge E. Hallyn [serue@us.ibm.com] wrote:
| Quoting Sukadev Bhattiprolu (sukadev@linux.vnet.ibm.com):
| >
| > Deny CLONE_PARENT|CLONE_NEWPID combination.
| >
| > CLONE_PARENT was used to implement an older threading model. For consistency
| > with the CLONE_THREAD check in copy_pid_ns(), disable CLONE_PARENT and
| > CLONE_SIGHAND with CLONE_NEWPID, at least until the required semantics of
| > the pid namespaces are clear.
| >
| > Changelog[v3]:
| > Remove CLONE_SIGHAND and for now only fail CLONE_NEWPID|CLONE_PARENT.
|
| (FWIW your patch description does not reflect this...)
You are right. Here is the patch with updated description.
---
Deny CLONE_PARENT|CLONE_NEWPID|CLONE_SIGHAND combination.
CLONE_PARENT was used to implement an older threading model. For consistency
with the CLONE_THREAD check in copy_pid_ns(), disable CLONE_PARENT with
CLONE_NEWPID, at least until the required semantics of pid namespaces are
clear.
Changelog[v3]:
Remove CLONE_SIGHAND and for now only fail CLONE_NEWPID|CLONE_PARENT.
Changelog[v2]:
[Eric Biederman] Disable CLONE_SIGHAND also ?
Signed-off-by: Sukadev Bhattiprolu <sukadev@us.ibm.com>
Acked-by: Roland McGrath <roland@redhat.com>
Acked-by: Serge Hallyn <serue@us.ibm.com>
---
kernel/pid_namespace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-mmotm/kernel/pid_namespace.c
===================================================================
--- linux-mmotm.orig/kernel/pid_namespace.c 2009-07-16 10:03:01.000000000 -0700
+++ linux-mmotm/kernel/pid_namespace.c 2009-07-16 11:37:24.000000000 -0700
@@ -118,7 +118,7 @@
{
if (!(flags & CLONE_NEWPID))
return get_pid_ns(old_ns);
- if (flags & CLONE_THREAD)
+ if (flags & (CLONE_THREAD|CLONE_PARENT))
return ERR_PTR(-EINVAL);
return create_pid_namespace(old_ns);
}
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-07-28 19:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-28 16:44 [PATCH] Deny CLONE_PARENT|CLONE_NEWPID combination Sukadev Bhattiprolu
2009-07-28 18:05 ` Serge E. Hallyn
2009-07-28 19:06 ` Sukadev Bhattiprolu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox