public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Jakob Gruber <jakob.gruber@kabelnet.at>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Missing device IDs in rt2870
Date: Tue, 28 Jul 2009 14:12:16 -0700	[thread overview]
Message-ID: <20090728211216.GA12363@suse.de> (raw)
In-Reply-To: <20090728230117.8fca2314.jakob.gruber@kabelnet.at>

On Tue, Jul 28, 2009 at 11:01:17PM +0200, Jakob Gruber wrote:
> >From http://bugzilla.kernel.org/show_bug.cgi?id=13459#c3
> 
> In rt2870.h, there are 2 lists of USB devices. One is within 
> 
> #ifndef RT30xx
> #endif
> 
> and the other in 
> 
> #ifdef RT30xx
> #endif

That kind of implies that the 2870 driver should not support this
device, right?

> 
> Since I'm not sure whether to add the devices to both lists or only the first,
> I'm posting a patch for both variations.
> 
> Patch 1, add devices only to first list:

Well, pick one :)

I'd prefer someone with one of these devices to test the patch and
verify that it works before blindly applying.  Fair enough?

thanks,

greg k-h

  reply	other threads:[~2009-07-28 21:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-28 21:01 Missing device IDs in rt2870 Jakob Gruber
2009-07-28 21:12 ` Greg KH [this message]
2009-07-29 15:11   ` Jakob Gruber
2009-07-29 16:16     ` Greg KH
2009-07-30 18:37       ` Jakob Gruber
2009-07-30 19:51         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090728211216.GA12363@suse.de \
    --to=gregkh@suse.de \
    --cc=jakob.gruber@kabelnet.at \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox