From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, stable@kernel.org
Cc: stable-review@kernel.org, torvalds@linux-foundation.org,
akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk,
Ben Hutchings <ben@decadent.org.uk>,
"David S. Miller" <davem@davemloft.net>
Subject: [patch 65/71] netdev: restore MAC address set and validate operations
Date: Tue, 28 Jul 2009 16:41:34 -0700 [thread overview]
Message-ID: <20090728234201.598624669@mini.kroah.org> (raw)
In-Reply-To: <20090728234756.GA11917@kroah.com>
[-- Attachment #1: netdev-restore-mac-address-set-and-validate-operations.patch --]
[-- Type: text/plain, Size: 5326 bytes --]
2.6.30-stable review patch. If anyone has any objections, please let us know.
------------------
From: Ben Hutchings <ben@decadent.org.uk>
commit 240c102d9c54fee7fdc87a4ef2fabc7eb539e00a upstream.
alloc_etherdev() used to install default implementations of these
operations, but they must now be explicitly installed in struct
net_device_ops.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/net/arm/ixp4xx_eth.c | 3 ++-
drivers/net/ehea/ehea_main.c | 1 +
drivers/net/gianfar.c | 2 ++
drivers/net/plip.c | 2 ++
drivers/net/ps3_gelic_net.c | 1 +
drivers/net/ps3_gelic_wireless.c | 1 +
drivers/net/sunvnet.c | 1 +
drivers/net/usb/kaweth.c | 2 ++
drivers/net/usb/pegasus.c | 2 ++
drivers/net/wireless/orinoco/main.c | 3 ++-
10 files changed, 16 insertions(+), 2 deletions(-)
--- a/drivers/net/arm/ixp4xx_eth.c
+++ b/drivers/net/arm/ixp4xx_eth.c
@@ -1140,7 +1140,8 @@ static const struct net_device_ops ixp4x
.ndo_start_xmit = eth_xmit,
.ndo_set_multicast_list = eth_set_mcast_list,
.ndo_do_ioctl = eth_ioctl,
-
+ .ndo_set_mac_address = eth_mac_addr,
+ .ndo_validate_addr = eth_validate_addr,
};
static int __devinit eth_init_one(struct platform_device *pdev)
--- a/drivers/net/ehea/ehea_main.c
+++ b/drivers/net/ehea/ehea_main.c
@@ -3081,6 +3081,7 @@ static const struct net_device_ops ehea_
#endif
.ndo_get_stats = ehea_get_stats,
.ndo_set_mac_address = ehea_set_mac_addr,
+ .ndo_validate_addr = eth_validate_addr,
.ndo_set_multicast_list = ehea_set_multicast_list,
.ndo_change_mtu = ehea_change_mtu,
.ndo_vlan_rx_register = ehea_vlan_rx_register,
--- a/drivers/net/gianfar.c
+++ b/drivers/net/gianfar.c
@@ -155,6 +155,8 @@ static const struct net_device_ops gfar_
.ndo_tx_timeout = gfar_timeout,
.ndo_do_ioctl = gfar_ioctl,
.ndo_vlan_rx_register = gfar_vlan_rx_register,
+ .ndo_set_mac_address = eth_mac_addr,
+ .ndo_validate_addr = eth_validate_addr,
#ifdef CONFIG_NET_POLL_CONTROLLER
.ndo_poll_controller = gfar_netpoll,
#endif
--- a/drivers/net/plip.c
+++ b/drivers/net/plip.c
@@ -270,6 +270,8 @@ static const struct net_device_ops plip_
.ndo_stop = plip_close,
.ndo_start_xmit = plip_tx_packet,
.ndo_do_ioctl = plip_ioctl,
+ .ndo_set_mac_address = eth_mac_addr,
+ .ndo_validate_addr = eth_validate_addr,
};
/* Entry point of PLIP driver.
--- a/drivers/net/ps3_gelic_net.c
+++ b/drivers/net/ps3_gelic_net.c
@@ -1410,6 +1410,7 @@ static const struct net_device_ops gelic
.ndo_set_multicast_list = gelic_net_set_multi,
.ndo_change_mtu = gelic_net_change_mtu,
.ndo_tx_timeout = gelic_net_tx_timeout,
+ .ndo_set_mac_address = eth_mac_addr,
.ndo_validate_addr = eth_validate_addr,
#ifdef CONFIG_NET_POLL_CONTROLLER
.ndo_poll_controller = gelic_net_poll_controller,
--- a/drivers/net/ps3_gelic_wireless.c
+++ b/drivers/net/ps3_gelic_wireless.c
@@ -2707,6 +2707,7 @@ static const struct net_device_ops gelic
.ndo_set_multicast_list = gelic_net_set_multi,
.ndo_change_mtu = gelic_net_change_mtu,
.ndo_tx_timeout = gelic_net_tx_timeout,
+ .ndo_set_mac_address = eth_mac_addr,
.ndo_validate_addr = eth_validate_addr,
#ifdef CONFIG_NET_POLL_CONTROLLER
.ndo_poll_controller = gelic_net_poll_controller,
--- a/drivers/net/sunvnet.c
+++ b/drivers/net/sunvnet.c
@@ -1017,6 +1017,7 @@ static const struct net_device_ops vnet_
.ndo_stop = vnet_close,
.ndo_set_multicast_list = vnet_set_rx_mode,
.ndo_set_mac_address = vnet_set_mac_addr,
+ .ndo_validate_addr = eth_validate_addr,
.ndo_tx_timeout = vnet_tx_timeout,
.ndo_change_mtu = vnet_change_mtu,
.ndo_start_xmit = vnet_start_xmit,
--- a/drivers/net/usb/kaweth.c
+++ b/drivers/net/usb/kaweth.c
@@ -982,6 +982,8 @@ static const struct net_device_ops kawet
.ndo_tx_timeout = kaweth_tx_timeout,
.ndo_set_multicast_list = kaweth_set_rx_mode,
.ndo_get_stats = kaweth_netdev_stats,
+ .ndo_set_mac_address = eth_mac_addr,
+ .ndo_validate_addr = eth_validate_addr,
};
static int kaweth_probe(
--- a/drivers/net/usb/pegasus.c
+++ b/drivers/net/usb/pegasus.c
@@ -1493,6 +1493,8 @@ static const struct net_device_ops pegas
.ndo_set_multicast_list = pegasus_set_multicast,
.ndo_get_stats = pegasus_netdev_stats,
.ndo_tx_timeout = pegasus_tx_timeout,
+ .ndo_set_mac_address = eth_mac_addr,
+ .ndo_validate_addr = eth_validate_addr,
};
static struct usb_driver pegasus_driver = {
--- a/drivers/net/wireless/orinoco/main.c
+++ b/drivers/net/wireless/orinoco/main.c
@@ -2521,6 +2521,8 @@ static const struct net_device_ops orino
.ndo_start_xmit = orinoco_xmit,
.ndo_set_multicast_list = orinoco_set_multicast_list,
.ndo_change_mtu = orinoco_change_mtu,
+ .ndo_set_mac_address = eth_mac_addr,
+ .ndo_validate_addr = eth_validate_addr,
.ndo_tx_timeout = orinoco_tx_timeout,
.ndo_get_stats = orinoco_get_stats,
};
@@ -2555,7 +2557,6 @@ struct net_device
priv->wireless_data.spy_data = &priv->spy_data;
dev->wireless_data = &priv->wireless_data;
#endif
- /* we use the default eth_mac_addr for setting the MAC addr */
/* Reserve space in skb for the SNAP header */
dev->hard_header_len += ENCAPS_OVERHEAD;
next prev parent reply other threads:[~2009-07-28 23:52 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090728234029.868717854@mini.kroah.org>
2009-07-28 23:47 ` [patch 00/71] [00/@num@] 2.6.30.4-stable review Greg KH
2009-07-28 23:40 ` [patch 01/71] SCSI: zalon: fix oops on attach failure Greg KH
2009-07-28 23:40 ` [patch 02/71] NFSD: Dont hold unrefcounted creds over call to nfsd_setuser() Greg KH
2009-07-28 23:40 ` [patch 03/71] sound: virtuoso: fix Xonar D1/DX silence after resume Greg KH
2009-07-28 23:40 ` [patch 04/71] sound: usb-audio: add workaround for Blue Microphones devices Greg KH
2009-07-28 23:40 ` [patch 05/71] fix RCU-callback-after-kmem_cache_destroy problem in sl[aou]b Greg KH
2009-07-28 23:40 ` [patch 06/71] dsa: fix 88e6xxx statistics counter snapshotting Greg KH
2009-07-28 23:40 ` [patch 07/71] gigaset: accept connection establishment messages in any order Greg KH
2009-07-28 23:40 ` [patch 08/71] cfg80211: fix refcount leak Greg KH
2009-07-28 23:40 ` [patch 09/71] Staging: prevent rtl8187se from crashing dev_ioctl() in SIOCGIWNAME Greg KH
2009-07-28 23:40 ` [patch 10/71] USB: handle zero-length usbfs submissions correctly Greg KH
2009-07-28 23:40 ` [patch 11/71] USB: ti_usb_3410_5052: fix duplicate device ids Greg KH
2009-07-28 23:40 ` [patch 12/71] USB: fix uninitialised variable in ti_do_download Greg KH
2009-07-28 23:40 ` [patch 13/71] USB: fix the clear_tt_buffer interface Greg KH
2009-07-28 23:40 ` [patch 14/71] USB: EHCI: use the new " Greg KH
2009-07-29 13:56 ` Alan Stern
2009-07-29 14:03 ` Greg KH
2009-07-29 14:24 ` Alan Stern
2009-07-29 14:44 ` Greg KH
2009-07-28 23:40 ` [patch 15/71] USB: fix memleak in usbfs Greg KH
2009-07-28 23:40 ` [patch 16/71] USB: RNDIS gadget, fix issues talking from PXA Greg KH
2009-07-28 23:40 ` [patch 17/71] USB: fix LANGID=0 regression Greg KH
2009-07-28 23:40 ` [patch 18/71] USB: EHCI: report actual_length for iso transfers Greg KH
2009-07-28 23:40 ` [patch 19/71] cifs: fix regression with O_EXCL creates and optimize away lookup Greg KH
2009-07-28 23:40 ` [patch 20/71] cifs: free nativeFileSystem field before allocating a new one Greg KH
2009-07-28 23:40 ` [patch 21/71] ALSA: ca0106 - Fix the max capture buffer size Greg KH
2009-07-28 23:40 ` [patch 22/71] ALSA: hda - Fix pin-setup for Sony VAIO with STAC9872 codecs Greg KH
2009-07-28 23:40 ` [patch 23/71] ALSA: hda - Add quirk for Gateway T6834c laptop Greg KH
2009-07-28 23:40 ` [patch 24/71] ALSA: hda - Fix mute control with some ALC262 models Greg KH
2009-07-28 23:40 ` [patch 25/71] HID: hiddev, fix lock imbalance Greg KH
2009-07-28 23:40 ` [patch 26/71] mvsdio: fix handling of partial word at the end of PIO transfer Greg KH
2009-07-28 23:40 ` [patch 27/71] ASoC: Fix register cache initialisation for WM8753 Greg KH
2009-07-28 23:40 ` [patch 28/71] partitions: fix broken uevent_suppress conversion Greg KH
2009-07-28 23:40 ` [patch 29/71] vc: create vcs(a) devices for consoles Greg KH
2009-07-28 23:40 ` [patch 30/71] x86: Fix fixmap ordering Greg KH
2009-07-28 23:41 ` [patch 31/71] x86: Fix fixmap page order for FIX_TEXT_POKE0,1 Greg KH
2009-07-28 23:41 ` [patch 32/71] block: fix sg SG_DXFER_TO_FROM_DEV regression Greg KH
2009-07-28 23:41 ` [patch 33/71] nilfs2: remove unlikely directive causing mis-conversion of error code Greg KH
2009-07-28 23:41 ` [patch 34/71] nilfs2: fix hang problem of log writer which occurs after write failures Greg KH
2009-07-28 23:41 ` [patch 35/71] nilfs2: fix incorrect KERN_CRIT messages in case of " Greg KH
2009-07-28 23:41 ` [patch 36/71] nilfs2: fix disorder in cp count on error during deleting checkpoints Greg KH
2009-07-28 23:41 ` [patch 37/71] sched_rt: Fix overload bug on rt group scheduling Greg KH
2009-07-28 23:41 ` [patch 38/71] tracing/function: Fix the return value of ftrace_trace_onoff_callback() Greg KH
2009-07-28 23:41 ` [patch 39/71] x86/pci: insert ioapic resource before assigning unassigned resources Greg KH
2009-07-28 23:41 ` [patch 40/71] sched: fix nr_uninterruptible accounting of frozen tasks really Greg KH
2009-07-28 23:41 ` [patch 41/71] dm raid1: wake kmirrord when requeueing delayed bios after remote recovery Greg KH
2009-07-28 23:41 ` [patch 42/71] x86: geode: Mark mfgpt irq IRQF_TIMER to prevent resume failure Greg KH
2009-07-28 23:41 ` [patch 43/71] x86: Fix movq immediate operand constraints in uaccess_64.h Greg KH
2009-07-28 23:41 ` [patch 44/71] x86: Fix movq immediate operand constraints in uaccess.h Greg KH
2009-07-28 23:41 ` [patch 45/71] x86: Add quirk for Intel DG45ID board to avoid low memory corruption Greg KH
2009-07-28 23:41 ` [patch 46/71] x86-64: Fix bad_srat() to clear all state Greg KH
2009-07-28 23:41 ` [patch 47/71] parisc: ensure broadcast tlb purge runs single threaded Greg KH
2009-07-28 23:41 ` [patch 48/71] parisc: fix ldcw inline assembler Greg KH
2009-07-28 23:41 ` [patch 49/71] x86, setup (2.6.30-stable) fix 80x34 and 80x60 console modes Greg KH
2009-07-28 23:41 ` [patch 50/71] Staging: rt2870: Add USB ID for Sitecom WL-608 Greg KH
2009-07-28 23:41 ` [patch 51/71] vmscan: do not unconditionally treat zones that fail zone_reclaim() as full Greg KH
2009-07-28 23:41 ` [patch 52/71] x86: dont use access_ok() as a range check in get_user_pages_fast() Greg KH
2009-07-28 23:41 ` [patch 53/71] mm: mark page accessed before we write_end() Greg KH
2009-07-28 23:41 ` [patch 54/71] elf: fix one check-after-use Greg KH
2009-07-28 23:41 ` [patch 55/71] hwmon: (max6650) Fix lock imbalance Greg KH
2009-07-28 23:41 ` [patch 56/71] powerpc/mpic: Fix mapping of "DCR" based MPIC variants Greg KH
2009-07-28 23:41 ` [patch 57/71] netfilter: nf_log: fix sleeping function called from invalid context Greg KH
2009-07-28 23:41 ` [patch 58/71] netfilter: nf_conntrack: fix confirmation race condition Greg KH
2009-07-28 23:41 ` [patch 59/71] netfilter: nf_conntrack: fix conntrack lookup race Greg KH
2009-07-28 23:41 ` [patch 60/71] netfilter: nf_log: fix direct userspace memory access in proc handler Greg KH
2009-07-28 23:41 ` [patch 61/71] netfilter: xt_quota: fix incomplete initialization Greg KH
2009-07-28 23:41 ` [patch 62/71] netfilter: xt_rateest: fix comparison with self Greg KH
2009-07-28 23:41 ` [patch 63/71] netfilter: tcp conntrack: fix unacknowledged data detection with NAT Greg KH
2009-07-28 23:41 ` [patch 64/71] nf_conntrack: nf_conntrack_alloc() fixes Greg KH
2009-07-28 23:41 ` Greg KH [this message]
2009-07-28 23:41 ` [patch 66/71] netdev: restore MTU change operation Greg KH
2009-07-28 23:41 ` [patch 67/71] Input: wistron_btns - recognize Maxdata Pro 7000 notebooks Greg KH
2009-07-28 23:41 ` [patch 68/71] libata: fix follow-up SRST failure path Greg KH
2009-07-28 23:41 ` [patch 69/71] nommu: Provide mmap_min_addr definition Greg KH
2009-07-28 23:41 ` [patch 70/71] eCryptfs: Check Tag 11 literal data buffer size (CVE-2009-2406) Greg KH
2009-07-28 23:41 ` [patch 71/71] eCryptfs: parse_tag_3_packet check tag 3 packet encrypted key size (CVE-2009-2407) Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090728234201.598624669@mini.kroah.org \
--to=gregkh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=stable-review@kernel.org \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox