From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Roland McGrath <roland@redhat.com>,
utrace-devel@redhat.com, linux-kernel@vger.kernel.org
Subject: [PATCH -mm] introduce tracehook_finish_jctl() helper
Date: Wed, 29 Jul 2009 04:01:40 +0200 [thread overview]
Message-ID: <20090729020139.GA7381@redhat.com> (raw)
(textually depends on signals-tracehook_notify_jctl-change.patch)
Introduce the empty inline tracehook_finish_jctl() helper called by
do_signal_stop() after wakeup.
Currently we lack the ability to report this state change.
Also fix the comment, it should be placed before schedule().
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
include/linux/tracehook.h | 9 +++++++++
kernel/signal.c | 2 ++
2 files changed, 11 insertions(+)
--- __UTRACE/include/linux/tracehook.h~2_FINISH_JCTL 2009-07-29 03:10:10.000000000 +0200
+++ __UTRACE/include/linux/tracehook.h 2009-07-29 03:51:42.000000000 +0200
@@ -521,6 +521,15 @@ static inline int tracehook_notify_jctl(
return notify ?: (current->ptrace & PT_PTRACED) ? why : 0;
}
+/**
+ * tracehook_finish_jctl - report about return from job control stop
+ *
+ * This is called by do_signal_stop() after wakeup.
+ */
+static inline void tracehook_finish_jctl(void)
+{
+}
+
#define DEATH_REAP -1
#define DEATH_DELAYED_GROUP_LEADER -2
--- __UTRACE/kernel/signal.c~2_FINISH_JCTL 2009-07-29 03:17:49.000000000 +0200
+++ __UTRACE/kernel/signal.c 2009-07-29 03:57:07.000000000 +0200
@@ -1735,12 +1735,12 @@ static int do_signal_stop(int signr)
read_unlock(&tasklist_lock);
}
+ /* Now we don't run again until woken by SIGCONT or SIGKILL */
do {
schedule();
} while (try_to_freeze());
- /*
- * Now we don't run again until continued.
- */
+
+ tracehook_finish_jctl();
current->exit_code = 0;
return 1;
next reply other threads:[~2009-07-29 2:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-29 2:01 Oleg Nesterov [this message]
2009-07-29 22:45 ` [PATCH -mm] introduce tracehook_finish_jctl() helper Roland McGrath
2009-07-29 22:50 ` Andrew Morton
2009-07-30 16:30 ` Oleg Nesterov
2009-08-01 23:32 ` Roland McGrath
2009-08-03 23:53 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090729020139.GA7381@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
--cc=utrace-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox