Re: [PATCH 4/4] Staging: hv: Fix warning by casting a (const void *) to (void *)

Greg KH
2009-07-29T13:13:16Z

On Wed, Jul 29, 2009 at 02:10:28PM +0200, Nicolas Palix wrote:
>
> Fix compilation warning by casting the const void *Buffer
> variable into a void *.
>
> Signed-off-by: Nicolas Palix <npalix@diku.dk>
> ---
> drivers/staging/hv/Channel.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/hv/Channel.c b/drivers/staging/hv/Channel.c
> index 68f3442..854fa30 100644
> --- a/drivers/staging/hv/Channel.c
> +++ b/drivers/staging/hv/Channel.c
> @@ -787,7 +787,7 @@ VmbusChannelSendPacket(
> bufferList[0].Data = &desc;
> bufferList[0].Length = sizeof(VMPACKET_DESCRIPTOR);
>
> - bufferList[1].Data = Buffer;
> + bufferList[1].Data = (void *)Buffer;

Yeah, I thought about doing this as well, but it's wrong. If this
buffer really isn't being modified, then the Data pointer needs to be
const.

Or, if the Data pointer really is going to not be const, then the
function parameters need to be changed, but that means lots of code
needs to be changed.

Hank, what do you think is the correct thing to do here?

thanks,

greg k-h