From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
john stultz <johnstul@us.ibm.com>,
Daniel Walker <dwalker@fifo99.com>
Subject: [RFC][patch 00/12] clocksource / timekeeping rework V2
Date: Wed, 29 Jul 2009 15:41:25 +0200 [thread overview]
Message-ID: <20090729134125.313191633@de.ibm.com> (raw)
Greetings,
version 2 of the clocksource / timekeeping cleanup patches. The series
has grown quite a bit, what started with a simple idea to replace the
tick based clocksource update with stop_machine is now a full fledged
code rework.
The code is working on s390 and on my Athlon system at home which has
a broken tsc clocksource:
[ 0.000000] Fast TSC calibration using PIT
[ 0.000341] hpet clockevent registered
[ 0.000343] HPET: 3 timers in total, 0 timers will be used for per-cpu timer
[ 0.204021] hpet0: at MMIO 0xfefff000, IRQs 2, 8, 31
[ 0.204027] hpet0: 3 comparators, 32-bit 25.000000 MHz counter
[ 0.208007] Switching to clock hpet
[ 0.211544] Switched to high resolution mode on CPU 0
[ 0.211960] Switched to high resolution mode on CPU 1
[ 8.000020] Clocksource tsc unstable (delta = -172310085 ns)
So the clocksource switch via stop_machine and the clocksource watchdog
are working. I keep the fingers crossed that nothing else breaks.
The patch set is based on todays upstream tree plus the patches from
the tip tree, if anyone wants to try them you need to pull from the
master branch of
git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-tip
There is still more room for improvement. Some sore points are:
1) The cycle_last value still is in the struct clocksource. It should
be in the struct timekeeper but the check against cycles_last in the
read function of the TSC clock source makes it hard.
2) read_persistent_clock returns seconds. With a really good initial
time source this is not very precise. read_persistent_clock should
return a struct timespec.
3) xtime, raw_time, total_sleep_time, timekeeping_suspended, jiffies,
the ntp state and probably a few other values may be better located
in the struct timekeeper as well.
and a few more I forgot.
Many thanks to John who pushed me into the right directions.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
next reply other threads:[~2009-07-29 13:42 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-29 13:41 Martin Schwidefsky [this message]
2009-07-29 13:41 ` [RFC][patch 01/12] introduce timekeeping_leap_insert Martin Schwidefsky
2009-07-30 21:02 ` john stultz
2009-07-29 13:41 ` [RFC][patch 02/12] remove clocksource inline functions Martin Schwidefsky
2009-07-29 14:15 ` Daniel Walker
2009-07-30 21:46 ` Christoph Hellwig
2009-07-30 21:05 ` john stultz
2009-07-29 13:41 ` [RFC][patch 03/12] cleanup clocksource selection Martin Schwidefsky
2009-07-29 13:41 ` [RFC][patch 04/12] clocksource watchdog highres enablement Martin Schwidefsky
2009-07-29 13:41 ` [RFC][patch 05/12] clocksource watchdog resume logic Martin Schwidefsky
2009-07-29 13:41 ` [RFC][patch 06/12] clocksource watchdog refactoring Martin Schwidefsky
2009-07-29 13:41 ` [RFC][patch 07/12] clocksource watchdog work Martin Schwidefsky
2009-07-29 13:41 ` [RFC][patch 08/12] introduce struct timekeeper Martin Schwidefsky
2009-07-29 13:41 ` [RFC][patch 09/12] add xtime_shift and ntp_error_shift to " Martin Schwidefsky
2009-07-30 22:15 ` john stultz
2009-07-31 8:13 ` Martin Schwidefsky
2009-07-29 13:41 ` [RFC][patch 10/12] move NTP adjusted clock multiplier " Martin Schwidefsky
2009-07-30 22:04 ` john stultz
2009-07-31 7:52 ` Martin Schwidefsky
2009-07-31 8:12 ` john stultz
2009-07-31 8:27 ` Martin Schwidefsky
2009-07-31 9:00 ` Martin Schwidefsky
2009-07-31 23:32 ` john stultz
2009-08-03 8:02 ` Martin Schwidefsky
2009-08-13 11:15 ` Linus Walleij
2009-08-13 11:23 ` Martin Schwidefsky
2009-07-29 13:41 ` [RFC][patch 11/12] timekeeper read clock helper functions Martin Schwidefsky
2009-07-30 21:39 ` john stultz
2009-07-31 7:45 ` Martin Schwidefsky
2009-07-31 8:11 ` john stultz
2009-07-29 13:41 ` [RFC][patch 12/12] update clocksource with stop_machine Martin Schwidefsky
2009-07-29 15:10 ` [RFC][patch 00/12] clocksource / timekeeping rework V2 Daniel Walker
[not found] <200907291510.n6TFAV8k000647@d06av06.portsmouth.uk.ibm.com>
2009-07-29 16:50 ` Martin Schwidefsky
2009-07-29 17:02 ` Daniel Walker
[not found] <200907291702.n6TH2LEt017305@d06av05.portsmouth.uk.ibm.com>
2009-07-29 17:09 ` Martin Schwidefsky
2009-07-29 17:17 ` Daniel Walker
2009-07-29 17:34 ` Daniel Walker
2009-07-30 7:42 ` Martin Schwidefsky
[not found] <200907291717.n6THHG6f001426@d06av06.portsmouth.uk.ibm.com>
2009-07-30 10:53 ` Martin Schwidefsky
2009-07-30 12:49 ` Daniel Walker
2009-07-30 13:04 ` Martin Schwidefsky
2009-07-30 13:49 ` Daniel Walker
2009-07-30 17:16 ` john stultz
2009-07-30 18:08 ` Daniel Walker
2009-07-30 20:37 ` Andreas Mohr
2009-07-30 20:56 ` john stultz
2009-07-31 5:33 ` Daniel Walker
2009-07-31 8:34 ` john stultz
2009-07-31 16:44 ` Daniel Walker
2009-07-30 17:12 ` john stultz
[not found] <200907301349.n6UDnCpx008890@d06av06.portsmouth.uk.ibm.com>
2009-07-30 15:42 ` Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090729134125.313191633@de.ibm.com \
--to=schwidefsky@de.ibm.com \
--cc=dwalker@fifo99.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox