Re: [RFC][patch 10/12] move NTP adjusted clock multiplier to struct timekeeper

Linus Walleij
2009-08-13T11:15:10Z

2009/7/29 Martin Schwidefsky <schwidefsky@de.ibm.com>:

> Index: linux-2.6/arch/arm/plat-omap/common.c
> ===================================================================
> --- linux-2.6.orig/arch/arm/plat-omap/common.c
> +++ linux-2.6/arch/arm/plat-omap/common.c
> @@ -256,7 +256,7 @@ unsigned long long sched_clock(void)
> unsigned long long ret;
>
> ret = (unsigned long long)clocksource_32k.read(&clocksource_32k);
> - ret = (ret * clocksource_32k.mult_orig) >> clocksource_32k.shift;
> + ret = (ret * clocksource_32k.mult) >> clocksource_32k.shift;

Doesn't the overall effect of your patch mean that the above can simply be
replaced by

ret = cyc2ns(&clocksource_32k, ret);

Or clocksource_cyc2ns() if that was renamed (I don't have the entire
picture here...)

> return ret;
> }

Yours,
Linus Walleij