From: Pavel Machek <pavel@ucw.cz>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Krzysztof Oledzki <olel@ans.pl>, Troy Moure <twmoure@szypr.net>,
Greg KH <gregkh@suse.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
stable@kernel.org, lwn@lwn.net,
Ian Lance Taylor <iant@google.com>
Subject: Re: Linux 2.6.27.27
Date: Wed, 29 Jul 2009 16:57:02 +0200 [thread overview]
Message-ID: <20090729145702.GA1534@ucw.cz> (raw)
In-Reply-To: <alpine.LFD.2.01.0907220846350.19335@localhost.localdomain>
> > > diff --git a/drivers/video/fbmon.c b/drivers/video/fbmon.c
> > > index 5c1a2c0..af4a15c 100644
> > > --- a/drivers/video/fbmon.c
> > > +++ b/drivers/video/fbmon.c
> > > @@ -256,8 +256,8 @@ static void fix_edid(unsigned char *edid, int fix)
> > >
> > > static int edid_checksum(unsigned char *edid)
> > > {
> > > - unsigned char i, csum = 0, all_null = 0;
> > > - int err = 0, fix = check_edid(edid);
> > > + unsigned csum = 0, all_null = 0;
> > > + int i, err = 0, fix = check_edid(edid);
>
> I don't know where the 'char' disappeared, but that was obviously not
> intended. I just meant to move the 'i' from one line to the other.
>
> > >
> > > if (fix)
> > > fix_edid(edid, fix);
> >
> > Tested-by: Krzysztof Piotr Oledzki <ole@ans.pl>
> >
> > On condition, that you keep "unsigned char" here. ;)
>
> Indeed. I'll commit the fixed version. Thanks for testing and sorry for
> the idiot patch.
So... we are going to just work around the gcc bug in the kernel?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2009-07-29 14:57 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-20 4:06 Linux 2.6.27.27 Greg KH
2009-07-20 4:07 ` Greg KH
2009-07-20 11:51 ` Krzysztof Oledzki
2009-07-20 15:10 ` Greg KH
2009-07-20 16:01 ` Linus Torvalds
2009-07-20 21:45 ` Krzysztof Oledzki
2009-07-20 22:08 ` Linus Torvalds
2009-07-20 23:47 ` Marc Dionne
2009-07-20 23:56 ` Linus Torvalds
2009-07-21 0:37 ` Marc Dionne
2009-07-21 1:01 ` Linus Torvalds
2009-07-21 6:40 ` Krzysztof Oledzki
2009-07-21 1:05 ` Linus Torvalds
2009-07-21 2:38 ` Marc Dionne
2009-07-21 6:33 ` Krzysztof Oledzki
2009-07-21 10:16 ` Krzysztof Oledzki
2009-07-21 16:11 ` Linus Torvalds
2009-07-21 19:15 ` Linus Torvalds
2009-07-21 21:34 ` Troy Moure
2009-07-22 0:53 ` Linus Torvalds
2009-07-22 1:07 ` Linus Torvalds
2009-07-22 6:16 ` Troy Moure
2009-07-22 15:58 ` Linus Torvalds
2009-07-22 1:16 ` Linus Torvalds
2009-07-22 8:12 ` Krzysztof Oledzki
2009-07-22 8:32 ` Krzysztof Oledzki
2009-07-22 9:55 ` Krzysztof Oledzki
2009-07-22 10:44 ` Krzysztof Oledzki
2009-07-22 9:58 ` Jens Rosenboom
2009-07-22 10:27 ` Troy Moure
2009-07-22 10:54 ` Krzysztof Oledzki
2009-07-22 10:24 ` Troy Moure
2009-07-22 10:33 ` Dick Streefland
2009-07-22 13:48 ` Krzysztof Oledzki
2009-07-22 15:48 ` Linus Torvalds
2009-07-29 14:57 ` Pavel Machek [this message]
2009-07-29 15:59 ` Linus Torvalds
2009-07-22 11:49 ` Krzysztof Oledzki
2009-07-22 13:27 ` Henrique de Moraes Holschuh
2009-07-22 13:45 ` Krzysztof Oledzki
2009-07-22 15:36 ` Ian Lance Taylor
2009-07-23 17:33 ` Krzysztof Olędzki
2009-07-24 21:13 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090729145702.GA1534@ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=iant@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lwn@lwn.net \
--cc=olel@ans.pl \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=twmoure@szypr.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox