Re: GFS2: Add LED support to GFS2

[Pavel Machek <pavel@ucw.cz>]

On Wed 2009-07-22 11:56:38, Steven Whitehouse wrote:
> >From e1fac35b9c2af276473db50fae581ef56626240c Mon Sep 17 00:00:00 2001
> From: Steven Whitehouse <swhiteho@redhat.com>
> Date: Wed, 22 Jul 2009 11:40:16 +0100
> Subject: [PATCH] GFS2: Add LED support to GFS2
> 
> This adds a standalone module which uses the GFS2 tracepoints
> as a hook to provide LED trigger events. Events can be sent
> when glocks change state, when glock demote requests are
> received (both local and remote events are included) and also
> when the log is flushed.
> 
> The log flush event lights the LED during the duration of the
> log flush event. The other two triggers light the LED for 1/10th
> second after the event has occurred.
> 
> I've tested this by using GFS2 in "nolock" mode on my laptop
> by getting it to flash the thinkpad battery LED on the various
> events and verified that it occurs when expected.

This looks way too specialized to me. Yes, it will be pretty,
but... there's about 100000 possible triggers. Where do we draw a
line? Or do we merge all of them?
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html