Re: MMC: Make the configuration memory resource optional

Ian Molton
2009-07-30T19:21:20Z

Guennadi Liakhovetski wrote:

> While you're at it, please, consider swapping the two lines in
> tmio_mmc_probe():
>
> - tmio_mmc_clk_stop(host);
> reset(host);
> + tmio_mmc_clk_stop(host);
>
> Otherwise, I think, reset causes problems trying to access the controller
> with disabled clock. At least this is needed on SuperH.

Interesting. I'll see what the result of this is on TMIO - This sequence
was garnered from the WinCE driver for the chip.

I cant see _why_ this should be a problem, as this disables the card
clock, not HCLK. Could you debug further in tmio_mmc_clk_stop() please
and see if reordering only one of the two IO accesses cures this?

Let me know what you find out.

-Ian