Re: MMC: Make the configuration memory resource optional

Ian Molton
2009-07-28T13:55:18Z

Guennadi Liakhovetski wrote:
> Add support for tmio_mmc hardware configurations, that lack the cnf io
> area, like SuperH SoCs. With this patch such hardware can pass a single
> ctl io area with the platform data.

NAK

I dont like this approach - although it involves minimal changes to the
driver, it will leave people puzzling over why their accesses to the cnf
registers do nothing when debugging.

The cnf area is basically clock and power control for devices that have
it. If I had known of the existence of other tmio devices that didnt do
it that way when I wrote the driver, it would never have been put in
there directly.

The *right* way to do this is to use the clk API for clocks and provide
a small API for power control that the driver will use, if present.

If people want to change the situation in TMIO re: clocks, as I have
said before, they should start a discussion on how to adapt the clk API.
so that more than just the CPU can use it. This will make everyone
happy all in one go.

I will happily take a patch abstracting power control from tmio-mmc,
however.

-Ian