Re: Missing device IDs in rt2870

[Greg KH <gregkh@suse.de>]

On Thu, Jul 30, 2009 at 08:37:36PM +0200, Jakob Gruber wrote:
> On Wed, 29 Jul 2009 09:16:43 -0700
> Greg KH <gregkh@suse.de> wrote:
> 
> <snip>
> > > 
> > > I haven't tested rt2870 in 2.6.30 thoroughly because of this bug
> > > (http://bugzilla.kernel.org/show_bug.cgi?id=13638), which forces me to
> > > use the driver from the Ralink website instead of the kernel module.
> > > However, I can confirm that - until running into the bug - the Belkin
> > > card also works in 2.6.30. 
> > 
> > Ah, that sucks.  I should revert that patch, if you do that, does the
> > device work properly for you?
> 
> 'git revert' didn't work out of the box, and I don't think I'm skilled
> enough to revert it manually :) However, I posted some more
> information at http://bugzilla.kernel.org/show_bug.cgi?id=13638#c9 ,
> including everything.log during the crash.

I just got confirmation from someone else on lkml that reverting this on
2.6.30.1 worked for them, so I'll port it to mainline and apply it there
as well as get it into the .30-stable tree.

> 
> > 
> > > A patch for adding the Belkin device ID is attached. I removed the
> > > other 2 IDs from http://bugzilla.kernel.org/show_bug.cgi?id=13459
> > > since I do not own these devices and cannot verify them. The ID is
> > > only added to the "#ifndef RT30xx" block, same as the patch applied to
> > > the Archlinux kernel.
> > 
> > I'll take the other two ids, now that it makes more sense.
> > 
> > Care to respin with the 2 new ids, and add a "Signed-off-by:" to the
> > patch so I can properly apply it?
> 
> Done, patch is attached. 

Looks good, I'll queue it up.

thanks,

greg k-h