From: Rusty Russell <rusty@rustcorp.com.au>
To: Dave Jones <davej@redhat.com>
Cc: "Langsdorf, Mark" <mark.langsdorf@amd.com>,
Eric Sesterhenn <eric.sesterhenn@lsexperts.de>,
linux-kernel@vger.kernel.org, cpufreq@vger.kernel.org
Subject: Re: Warning during suspend with MS-7310 mainboard
Date: Fri, 31 Jul 2009 08:37:22 +0930 [thread overview]
Message-ID: <200907310837.23487.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20090730164629.GC2593@redhat.com>
On Fri, 31 Jul 2009 02:16:29 am Dave Jones wrote:
> On Thu, Jul 30, 2009 at 11:38:22AM -0500, Langsdorf, Mark wrote:
> > I'll look into it.
> >
> > First time I've had this bug reported, though.
> >
>
> It's happening because the suspend code runs with interrupts disabled,
> and the powerpc workaround we do in the cpufreq suspend hook
> calls the drivers ->get method.
>
> powernow-k8's ->get does an smp_call_function_single
> which needs interrupts enabled
Yeah, I was confused: my patch changed set_cpus_allowed_ptr() to
an smp_call_function. If the latter is a bad idea with irqs disabled, the
former certainly was...
Thanks,
Rusty.
next prev parent reply other threads:[~2009-07-30 23:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-30 6:50 Warning during suspend with MS-7310 mainboard Eric Sesterhenn
2009-07-30 10:27 ` Eric Sesterhenn
2009-07-30 15:47 ` Dave Jones
2009-07-30 16:38 ` Langsdorf, Mark
2009-07-30 16:46 ` Dave Jones
2009-07-30 17:11 ` Langsdorf, Mark
2009-07-30 23:07 ` Rusty Russell [this message]
2009-07-30 23:17 ` Dave Jones
2009-08-03 6:34 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907310837.23487.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=cpufreq@vger.kernel.org \
--cc=davej@redhat.com \
--cc=eric.sesterhenn@lsexperts.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.langsdorf@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox