From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Arnaud Faucher <arnaud.faucher@gmail.com>
Cc: Carlos Corbacho <carlos@strangeworlds.co.uk>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Frans Pop <elendil@planet.nl>,
Manuel Lauss <manuel.lauss@gmail.com>, Erik Ekman <erik@kryo.se>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH 1/1] acer-wmi: switch driver to dev_pm_ops
Date: Fri, 31 Jul 2009 13:56:56 +0200 [thread overview]
Message-ID: <200907311356.57529.rjw@sisk.pl> (raw)
In-Reply-To: <1248991509.4901.9.camel@green>
On Friday 31 July 2009, Arnaud Faucher wrote:
> On Wed, Jul 29, 2009 at 18:53 -0400, Arnaud Faucher wrote :
> > As of today, acer_platform_freeze() does not stop/reset any device, so,
> > I agree with Rafael that for acer-wmi, .thaw() can be skipped. I had
> > also tested this configuration and it was working like the non-patched
> > code.
> >
> > Carlos, do you think that any acer-specific hardware could be switched
> > off or reset inside acer_platform_freeze() ? If this was the case, we
> > would have to wire .thaw()...
> >
>
> Should I send a new patch with only .freeze() and .restore() wired ?
Just for clarification.
If you need .freeze(), then you need .suspend() as well (they can both point
to the same function). Similarly, if you .restore(), then .resume() is needed
as well.
Otherwise the driver is going to break suspend to RAM (or resume).
Best,
Rafael
next prev parent reply other threads:[~2009-07-31 11:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-25 13:04 [PATCH 1/1] acer-wmi: switch driver to dev_pm_ops Arnaud Faucher
2009-07-25 17:43 ` Dmitry Torokhov
2009-07-25 20:04 ` Rafael J. Wysocki
2009-07-26 13:53 ` Arnaud Faucher
2009-07-26 14:23 ` Carlos Corbacho
2009-07-26 18:08 ` Dmitry Torokhov
2009-07-26 18:35 ` Carlos Corbacho
2009-07-26 20:28 ` Arnaud Faucher
2009-07-26 21:33 ` Dmitry Torokhov
2009-07-26 22:51 ` Arnaud Faucher
2009-07-28 23:39 ` Arnaud Faucher
2009-07-29 20:49 ` Rafael J. Wysocki
2009-07-29 21:03 ` Dmitry Torokhov
2009-07-29 22:53 ` Arnaud Faucher
2009-07-30 22:05 ` Arnaud Faucher
2009-07-31 11:56 ` Rafael J. Wysocki [this message]
2009-07-29 23:27 ` Rafael J. Wysocki
2009-07-25 20:10 ` Arnaud Faucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907311356.57529.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=arnaud.faucher@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=carlos@strangeworlds.co.uk \
--cc=dmitry.torokhov@gmail.com \
--cc=elendil@planet.nl \
--cc=erik@kryo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=manuel.lauss@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox