public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Roger Quadros <quadros.roger@gmail.com>
Cc: pHilipp Zabel <philipp.zabel@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] regulator: Add GPIO enable control to fixed voltage regulator driver
Date: Fri, 31 Jul 2009 22:44:01 +0100	[thread overview]
Message-ID: <20090731214401.GC6335@sirena.org.uk> (raw)
In-Reply-To: <b90c0690907311332o958b7f4nd025aa7a8b273a88@mail.gmail.com>

On Fri, Jul 31, 2009 at 11:32:32PM +0300, Roger Quadros wrote:

> Not having gpio_get_direction() in gpiolib is a limitation I think.
> Can we just do the following for now ? (i.e. disable regulator by default)
> Will there be any glitch? If yes, then how?

If you're going to do this then like I say you should make the default
state controllable by platform data.  If we unconditionally disable the
regulator then if, for example, the regulator is controlling the display
backlight and it's on when Linux get controls then the user will see the
backlight blink off then on during startup.

  reply	other threads:[~2009-07-31 21:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-31 16:19 [PATCH v2] regulator: Add GPIO enable control to fixed voltage regulator driver Roger Quadros
2009-07-31 17:01 ` Felipe Balbi
2009-07-31 17:03 ` pHilipp Zabel
2009-07-31 17:20 ` Mark Brown
2009-07-31 17:38   ` pHilipp Zabel
2009-07-31 20:32     ` Roger Quadros
2009-07-31 21:44       ` Mark Brown [this message]
2009-08-01  5:57         ` Roger Quadros
2009-08-01  9:48           ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090731214401.GC6335@sirena.org.uk \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=philipp.zabel@gmail.com \
    --cc=quadros.roger@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox