From: Ingo Molnar <mingo@elte.hu>
To: Kyle McMartin <kyle@mcmartin.ca>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
Jens Axboe <jens.axboe@oracle.com>,
Anton Blanchard <anton@samba.org>,
davem@davemloft.net, linux-kernel@vger.kernel.org,
a.p.zijlstra@chello.nl, fweisbec@gmail.com,
benh@kernel.crashing.org, penberg@cs.helsinki.fi,
vegard.nossum@gmail.com, paulus@samba.org, williams@redhat.com
Subject: Re: [PATCH] basic perf support for sparc
Date: Sun, 2 Aug 2009 21:50:43 +0200 [thread overview]
Message-ID: <20090802195043.GD24486@elte.hu> (raw)
In-Reply-To: <20090802194454.GC28572@bombadil.infradead.org>
* Kyle McMartin <kyle@mcmartin.ca> wrote:
> On Sun, Aug 02, 2009 at 08:41:48PM +0200, Ingo Molnar wrote:
> > Could we somehow define a weak symbol for those library functions
> > ourselves and thus just fall back to that (which does nothing)
> > instead of failing the link?
> >
>
> Well, you could just dlopen the object, but that's kind of
> gross...
hm, why is it gross? I think it's a nicely plug-and-play tooling
solution - instead of some obscure make flag.
Since we define the prototype anyway:
> +static inline char *bfd_demangle(void __used *v, const char __used *c,
> + int __used i) {
> + return NULL;
> +}
We are sticking to a given version of the API. We could turn that
into a function pointer and fill it in during startup via dlopen().
If it's NULL then we dont call it and assume a value of NULL.
Mind submitting such a version of your fix? It would nicely decrease
the build requirements cross section surface of perf.
Ingo
next prev parent reply other threads:[~2009-08-02 19:51 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-29 11:25 [PATCH] basic perf support for sparc Jens Axboe
2009-07-29 19:28 ` Jens Axboe
2009-08-01 1:14 ` Anton Blanchard
2009-08-01 8:20 ` Jens Axboe
2009-08-01 18:22 ` Arnaldo Carvalho de Melo
2009-08-02 18:41 ` Ingo Molnar
2009-08-02 19:44 ` Kyle McMartin
2009-08-02 19:50 ` Ingo Molnar [this message]
2009-08-02 20:11 ` Kyle McMartin
2009-08-02 20:33 ` Ingo Molnar
2009-08-02 20:47 ` Arnaldo Carvalho de Melo
2009-08-03 1:54 ` Arnaldo Carvalho de Melo
2009-08-04 3:33 ` Kyle McMartin
2009-08-04 9:25 ` Ingo Molnar
2009-08-04 9:29 ` Peter Zijlstra
2009-08-04 13:02 ` David Miller
2009-08-04 10:32 ` Frederic Riss
2009-08-04 10:38 ` Peter Zijlstra
2009-08-04 11:23 ` Frederic Riss
2009-08-04 11:28 ` Ingo Molnar
2009-08-05 12:10 ` Peter Zijlstra
2009-08-05 12:21 ` Jens Axboe
2009-08-05 12:33 ` Ingo Molnar
2009-08-05 12:16 ` [tip:perfcounters/urgent] perf: Auto-detect libbfd tip-bot for Peter Zijlstra
2009-08-05 14:29 ` Peter Zijlstra
2009-08-05 18:58 ` Peter Zijlstra
2009-08-02 20:17 ` [PATCH] basic perf support for sparc David Miller
2009-08-02 20:25 ` Ingo Molnar
2009-08-06 7:02 ` Jens Axboe
2009-08-12 18:06 ` David Miller
2009-08-12 18:13 ` Jens Axboe
2009-08-17 1:31 ` David Miller
2009-08-17 6:48 ` Jens Axboe
2009-08-17 7:57 ` Ingo Molnar
2009-09-04 4:37 ` David Miller
2009-09-04 5:02 ` Ingo Molnar
2009-09-04 5:09 ` David Miller
2009-09-04 5:20 ` Jens Axboe
2009-09-04 6:34 ` Jens Axboe
2009-09-04 6:44 ` Ingo Molnar
2009-09-04 9:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090802195043.GD24486@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=fweisbec@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=kyle@mcmartin.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=penberg@cs.helsinki.fi \
--cc=vegard.nossum@gmail.com \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox