public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Ray Lee <ray-lk@madrabbit.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Mike Galbraith <efault@gmx.de>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1 tip] perf top: Move hard coded list to /etc/perfconfig/symbols.skip
Date: Sun, 2 Aug 2009 16:59:45 -0300	[thread overview]
Message-ID: <20090802195945.GD25334@ghostprotocols.net> (raw)
In-Reply-To: <20090802195533.GE24486@elte.hu>

Em Sun, Aug 02, 2009 at 09:55:33PM +0200, Ingo Molnar escreveu:
> 
> * Ray Lee <ray-lk@madrabbit.org> wrote:
> 
> > On Mon, Jul 27, 2009 at 5:10 PM, Arnaldo Carvalho de
> > Melo<acme@redhat.com> wrote:
> > > This also paves the way to add more symbol lists to be filtered out,
> > > spinlock anyone?
> > 
> > Generally, the way I've found is best to handle things like this is to either:
> > 
> > A. Have a fall-back list to use if the file isn't found, or
> > B. Start with the fall-back list of symbols to filter, then add to
> > them via /etc/... and ~/.perf/...
> > 
> > I like approaching things from the 'everything works even in a
> > broken/hasty installation' point of view, and it's paid off for me.
> > Sane defaults are a wonderfully useful thing.
> 
> Agreed.
> 
> Also, i'd not pollute /etc just yet, please lets define a good 
> default built-in list like we have now, and perhaps enable the 
> extension of it via .perf/config.
> 
> Tools should work well by default.

OK, I'll rework the patch and resubmit it.

- Arnaldo

  reply	other threads:[~2009-08-02 20:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-28  0:10 [PATCH 1/1 tip] perf top: Move hard coded list to /etc/perfconfig/symbols.skip Arnaldo Carvalho de Melo
2009-07-28  3:18 ` Frederic Weisbecker
2009-07-28 14:13   ` Arnaldo Carvalho de Melo
2009-07-28  3:58 ` Ray Lee
2009-07-28 14:17   ` Arnaldo Carvalho de Melo
2009-07-28 15:35     ` Ray Lee
2009-08-02 19:55   ` Ingo Molnar
2009-08-02 19:59     ` Arnaldo Carvalho de Melo [this message]
2009-07-28  7:07 ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090802195945.GD25334@ghostprotocols.net \
    --to=acme@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=efault@gmx.de \
    --cc=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=ray-lk@madrabbit.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox