Re: [RFC] Make AGP work with IOMMU

[Zhenyu Wang <zhenyuw@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1295 bytes --]

On 2009.07.29 17:36:45 +0800, David Woodhouse wrote:
> On Wed, 2009-07-29 at 18:43 +1000, Dave Airlie wrote:
> > >> don't suppose we want page_to_gart or is the double function nicer?
> > >
> > > I pondered that briefly. But then observed that phys_to_gart() and
> > > gart_to_phys() _always_ describe an identity mapping, so perhaps they
> > > could just be ditched completely?
> > 
> > Yeah that could work too, no idea why they were introduced, well before my time.
> 
> http://git.infradead.org/users/dwmw2/iommu-agp.git?a=commitdiff;h=8bf2f3a9
> 
> It was introduced by Keir in 2005 for Xen (commit 07eee78e). I suspect
> it can die though, and that the right answer there is also to use the
> DMA API correctly.
> 

The commits on that tree looks fine to me. Thanks David! 
I've also done some testing on G45 here, I've also seen the write
faults before graphics device init or after dma unmap pages. I tried
to look it up in my memo, which turns out one message like this should
be a BIOS bug that doesn't initialize the GTT table correctly. But I'm
quite sure about it now, better to ask our chipset people to verify if
this problem has been fixed or not.

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]