Re: [PATCH v2] acpi_power_meter: hwmon driver for ACPI 4.0 power meters

Darrick J. Wong
2009-08-18T16:24:08Z

On Mon, Aug 17, 2009 at 03:05:58PM -0700, Andrew Morton wrote:
> > + if (ACPI_FAILURE(status)) {
> > + ACPI_EXCEPTION((AE_INFO, status, "Evaluating _PAI"));
> > + return -EINVAL;
> > + }
> > +
> > + if (data)
> > + return -EINVAL;
>
> I find this test of `data' inexplicable. Is it just me, or do we need
> a comment here?

ACPI spec says that the _PAI method passes back 0 on success. I guess I'll
reroll the patch with a comment stating that.

> > + if (ACPI_FAILURE(status)) {
> > + ACPI_EXCEPTION((AE_INFO, status, "Evaluating _SHL"));
> > + return -EINVAL;
> > + }
> > +
> > + if (data)
> > + return -EINVAL;
>
> ditto.

Ditto.

--D