linux-next: cpufreq tree build failure

linux-next: cpufreq tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 520 bytes --]

Hi Dave,

Today's linux-next build (x86_64 allmodconfig) failed like this:

ERROR: "cpufreq_global_kobject" [drivers/cpufreq/cpufreq_ondemand.ko] undefined!

Caused by commit 35b104d88338e5eddb36c670fea4752f6c10c82f ("[CPUFREQ]
ondemand - Use global sysfs dir for tuning settings").  Presumably
cpufreq_global_kobject needs an EXPORT_SYMBOL.

I have used the cpufreq tree from next-20090731 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: cpufreq tree build failure

[Thomas Renninger]

On Monday 03 August 2009 04:28:19 am Stephen Rothwell wrote:
> Hi Dave,
>
> Today's linux-next build (x86_64 allmodconfig) failed like this:
>
> ERROR: "cpufreq_global_kobject" [drivers/cpufreq/cpufreq_ondemand.ko]
> undefined!
>
> Caused by commit 35b104d88338e5eddb36c670fea4752f6c10c82f ("[CPUFREQ]
> ondemand - Use global sysfs dir for tuning settings").  Presumably
> cpufreq_global_kobject needs an EXPORT_SYMBOL.

Yep, that's it. Below is a fix.

Thanks a lot,

     Thomas

---------
CPUFREQ: fix build if ondemand is compiled as module

struct kobject *cpufreq_global_kobject must be exported

CC: Stephen Rothwell <sfr@canb.auug.org.au>
CC: Dave Jones <davej@redhat.com>
Signed-off-by: Thomas Renninger <trenn@suse.de>

diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 9bb2c4a..9d9251f 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -778,6 +778,7 @@ define_one_global_ro(scaling_driver);
 define_one_global_rw(scaling_governor);
 
 struct kobject *cpufreq_global_kobject;
+EXPORT_SYMBOL(cpufreq_global_kobject);
 
 #define to_policy(k) container_of(k, struct cpufreq_policy, kobj)
 #define to_attr(a) container_of(a, struct freq_attr, attr)

Re: linux-next: cpufreq tree build failure

[Dave Jones]

On Tue, Aug 04, 2009 at 01:22:14AM +0200, Thomas Renninger wrote:
 > On Monday 03 August 2009 04:28:19 am Stephen Rothwell wrote:
 > > Hi Dave,
 > >
 > > Today's linux-next build (x86_64 allmodconfig) failed like this:
 > >
 > > ERROR: "cpufreq_global_kobject" [drivers/cpufreq/cpufreq_ondemand.ko]
 > > undefined!
 > >
 > > Caused by commit 35b104d88338e5eddb36c670fea4752f6c10c82f ("[CPUFREQ]
 > > ondemand - Use global sysfs dir for tuning settings").  Presumably
 > > cpufreq_global_kobject needs an EXPORT_SYMBOL.
 > 
 > Yep, that's it. Below is a fix.
 > 
 > Thanks a lot,

I'll roll this in with the previous patch, so as not to introduce
a bisect-regression, and rebase the tree. Will push something out
soon.

thanks.

	Dave