From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751743AbZHDEJc (ORCPT ); Tue, 4 Aug 2009 00:09:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750839AbZHDEJb (ORCPT ); Tue, 4 Aug 2009 00:09:31 -0400 Received: from kroah.org ([198.145.64.141]:40745 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750810AbZHDEJb (ORCPT ); Tue, 4 Aug 2009 00:09:31 -0400 Date: Mon, 3 Aug 2009 21:08:34 -0700 From: Greg KH To: Linus Torvalds Cc: Sergey Senozhatsky , Alan Cox , OGAWA Hirofumi , Linux Kernel Mailing List Subject: Re: proper tty-ldisc refcounting (was Re: WARNING at: drivers/char/tty_ldisc.c) Message-ID: <20090804040834.GA16696@kroah.com> References: <87k51l9apo.fsf@devron.myhome.or.jp> <20090802234851.3fd1ac2c@lxorguk.ukuu.org.uk> <20090803181811.GA15848@kroah.com> <20090804003009.GA3121@localdomain.by> <20090804035319.GA7248@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090804035319.GA7248@kroah.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 03, 2009 at 08:53:19PM -0700, Greg KH wrote: > On Mon, Aug 03, 2009 at 05:56:07PM -0700, Linus Torvalds wrote: > > > > > > On Tue, 4 Aug 2009, Sergey Senozhatsky wrote: > > > > > > Works for me (SMP/non-SMP x86 builds). Great job. > > > > > > Tested-by: Sergey Senozhatsky > > > > Thanks. > > > > Greg - feel free to treat 4/2 and 5/2 any way you want. They are obvious > > enough (no subtle issues) that I'll happily pull them into 2.6.31 too: > > relative to the initial refcount changes (which it looks like we'll need > > to do just to fix the regression) they are pretty safe. > > > > But at the same time, they can equally well go into some later tree for > > the next merge window. So whatever you want to do. > > I'll queue them up for .32 as they don't fix a bug that people are > hitting from what I can tell. Oh wait, the original problem, single user mode. Hm, we need all of these to fix that problem? Or just the first one? thanks, greg k-h