From: Albin Tonnerre <albin.tonnerre@free-electrons.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Frans Pop <elendil@planet.nl>,
linux-kernel@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Linux PM List <linux-pm@lists.linux-foundation.org>
Subject: [PATCH] Add SIMPLE_PM_OPS: make switching to dev_pm_ops less error-prone
Date: Tue, 4 Aug 2009 11:36:12 +0200 [thread overview]
Message-ID: <20090804093542.GA5854@laptop> (raw)
In-Reply-To: <200908032123.17069.rjw@sisk.pl>
In a number of cases, the .suspend, .freeze, .poweroff and .resume,
.thaw, .restore functions are identical. However, they all need to be
assigned to avoid regressionsm as the previous code called .suspend
resp. .resume in all those cases. SIMPLE_PM_OPS allows to deal with
this case.
Signed-off-by: Albin Tonnerre <albin.tonnerre@free-electrons.com>
---
include/linux/pm.h | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/include/linux/pm.h b/include/linux/pm.h
index b3f7476..994a62f 100644
--- a/include/linux/pm.h
+++ b/include/linux/pm.h
@@ -184,6 +184,16 @@ struct dev_pm_ops {
int (*restore_noirq)(struct device *dev);
};
+#define SIMPLE_PM_OPS(name, suspend_fn, resume_fn) \
+struct dev_pm_ops name = { \
+ .suspend = suspend_fn, \
+ .resume = resume_fn, \
+ .freeze = suspend_fn, \
+ .thaw = resume_fn, \
+ .poweroff = suspend_fn, \
+ .resume = resume_fn, \
+}
+
/**
* PM_EVENT_ messages
*
--
Albin Tonnerre, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2009-08-04 9:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-03 16:33 [PATCH V2] au1xmmc: dev_pm_ops conversion Albin Tonnerre
2009-08-03 19:23 ` Rafael J. Wysocki
2009-08-04 9:36 ` Albin Tonnerre [this message]
2009-08-05 4:55 ` [PATCH] Add SIMPLE_PM_OPS: make switching to dev_pm_ops less error-prone Dmitry Torokhov
2009-08-05 9:37 ` Albin Tonnerre
2009-08-05 18:47 ` Rafael J. Wysocki
2009-08-05 20:05 ` [PATCH] PM: Add convenience macro to " Rafael J. Wysocki
2009-08-05 20:17 ` pHilipp Zabel
2009-08-05 20:22 ` Frans Pop
2009-08-05 21:30 ` Rafael J. Wysocki
2009-08-06 8:51 ` Daniel Mack
2009-08-06 12:16 ` Rafael J. Wysocki
2009-08-06 13:10 ` Magnus Damm
2009-08-06 15:14 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090804093542.GA5854@laptop \
--to=albin.tonnerre@free-electrons.com \
--cc=dmitry.torokhov@gmail.com \
--cc=elendil@planet.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox