From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754287AbZHDLbQ (ORCPT ); Tue, 4 Aug 2009 07:31:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753844AbZHDLbP (ORCPT ); Tue, 4 Aug 2009 07:31:15 -0400 Received: from mga05.intel.com ([192.55.52.89]:52524 "EHLO fmsmga101.fm.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753756AbZHDLbP (ORCPT ); Tue, 4 Aug 2009 07:31:15 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.43,321,1246863600"; d="scan'208";a="713745219" Date: Tue, 4 Aug 2009 13:33:15 +0200 From: Samuel Ortiz To: Mark Brown Cc: Jean Delvare , linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org Subject: Re: [PATCH] hwmon: WM831x PMIC hardware monitoring driver Message-ID: <20090804113314.GA8601@sortiz.org> References: <1248702372-29534-12-git-send-email-broonie@opensource.wolfsonmicro.com> <1248790260-26211-1-git-send-email-broonie@opensource.wolfsonmicro.com> <20090728162658.0ac35362@hyperion.delvare> <20090728145048.GB3013@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090728145048.GB3013@sirena.org.uk> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jean, Mark, On Tue, Jul 28, 2009 at 03:50:49PM +0100, Mark Brown wrote: > On Tue, Jul 28, 2009 at 04:26:58PM +0200, Jean Delvare wrote: > > On Tue, 28 Jul 2009 15:11:00 +0100, Mark Brown wrote: > > > > +static ssize_t show_batt_temp(struct device *dev, > > > + struct device_attribute *attr, char *buf) > > > +{ > > ... > > > > + /* The conversion depends on the battery, leave to userspace but > > > + * report as voltage for ABI reasons. */ > > > + return sprintf(buf, "%d\n", DIV_ROUND_CLOSEST(ret, 1000)); > > > +} > > > If I am not mistaken, the above function is an exact copy of > > show_voltage(), so you might as well use it? > > It is now, yes, except for the comment explaining why we're reporting as > a voltage. > > > All the rest looks good to me now, so: > > > Acked-by: Jean Delvare > > > And as I said before for the wm8350-hwmon driver: I can pick this patch > > and push it to Linux in 2.6.32 if you want, but if you want it to take > > a different route this is equally fine with me. Just tell me if you > > want me to pick it. > > I'm more than happy for you to take both - the only reason that I asked > you to hold off on the wm8350 patch originally was that I knew I was > going to be releasing this driver and there would be collisions with the > Kconfig stuff which was due to be released very soon. I applied both patches to my for-next branch. Jean, if you prefer them to go through your tree, please go ahead and I'll remove them from mine. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/