Re: [PATCH 0/3] Generic sysfs support for ACPI ALS and other ALS devices

Zhang Rui
2009-08-05T04:28:52Z

On Tue, 2009-08-04 at 23:10 +0800, Greg KH wrote:
> On Tue, Aug 04, 2009 at 03:21:29PM +0200, Pavel Machek wrote:
> > On Mon 2009-08-03 17:10:57, Zhang Rui wrote:
> > > Hi, all,
> > >
> > > This is the patch set I made to introduce ACPI ALS device driver
> > > and a generic sysfs I/F for all the ALS devices, like ACPI ALS,
> > > platform ALS, etc.
> > >
> > > Patch 01 introduces the ACPI ALS device driver.
> > >
> > > Patch 02 introduces ALS sysfs class.
> > > Two sysfs I/F are created for each ALS device.
> > > /sys/class/als/alsX/illuminance:
> > > the amount of light incident upon a specified surface area.
> > > /sys/class/als/alsX/mappings:
> > > ambient light illuminance to display luminance mappings
> > > that can be used by an OS to calibrate its ambient light policy
> > > this is what I got on a test box:
> > > cat /sys/class/als/als0/mappings
> > > ???Illuminance Adjustment
> > > 0 70
> > > 10 73
> > > 80 85
> > > 300 100
> > > 1000 150
> >
> > There's one value per file for sysfs... You should definitely have the
> > header.
>
> No, no "header", just don't do this, it's not allowed. Again,
> one-value-per-sysfs-file is the rule, please do not violate it.
>
Okay.
how about
﻿/sys/class/als/als0/mapping{0, 1, ...}/illuminance
and
﻿﻿/sys/class/als/als0/mapping{0, 1, ...}/adjustment

> > Plus I'd say Documentation/ file is needed.
>
> It's required for any new sysfs file being added to the kernel.
>
Okay, I'll add the document file.

thanks,
rui