From: "Serge E. Hallyn" <serue@us.ibm.com>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@osdl.org, akpm@linux-foundation.org, jmorris@namei.org,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH 6/6] KEYS: Do some whitespace cleanups
Date: Tue, 4 Aug 2009 13:46:18 -0500 [thread overview]
Message-ID: <20090804184618.GD8442@us.ibm.com> (raw)
In-Reply-To: <20090804145556.17676.80359.stgit@warthog.procyon.org.uk>
Quoting David Howells (dhowells@redhat.com):
> Do some whitespace cleanups in the key management code.
>
> Signed-off-by: David Howells <dhowells@redhat.com>
(trivially correct of course)
Acked-by: Serge Hallyn <serue@us.ibm.com>
> ---
>
> security/keys/proc.c | 12 +++---------
> 1 files changed, 3 insertions(+), 9 deletions(-)
>
>
> diff --git a/security/keys/proc.c b/security/keys/proc.c
> index 643ecf0..e4fde23 100644
> --- a/security/keys/proc.c
> +++ b/security/keys/proc.c
> @@ -194,11 +194,9 @@ static int proc_keys_show(struct seq_file *m, void *v)
> /* come up with a suitable timeout value */
> if (key->expiry == 0) {
> memcpy(xbuf, "perm", 5);
> - }
> - else if (now.tv_sec >= key->expiry) {
> + } else if (now.tv_sec >= key->expiry) {
> memcpy(xbuf, "expd", 5);
> - }
> - else {
> + } else {
> timo = key->expiry - now.tv_sec;
>
> if (timo < 60)
> @@ -238,9 +236,7 @@ static int proc_keys_show(struct seq_file *m, void *v)
> seq_putc(m, '\n');
>
> rcu_read_unlock();
> -
> return 0;
> -
> }
>
> #endif /* CONFIG_KEYS_DEBUG_PROC_KEYS */
> @@ -266,6 +262,7 @@ static struct rb_node *key_user_first(struct rb_root *r)
> struct rb_node *n = rb_first(r);
> return __key_user_next(n);
> }
> +
> /*****************************************************************************/
> /*
> * implement "/proc/key-users" to provides a list of the key users
> @@ -273,7 +270,6 @@ static struct rb_node *key_user_first(struct rb_root *r)
> static int proc_key_users_open(struct inode *inode, struct file *file)
> {
> return seq_open(file, &proc_key_users_ops);
> -
> }
>
> static void *proc_key_users_start(struct seq_file *p, loff_t *_pos)
> @@ -290,14 +286,12 @@ static void *proc_key_users_start(struct seq_file *p, loff_t *_pos)
> }
>
> return _p;
> -
> }
>
> static void *proc_key_users_next(struct seq_file *p, void *v, loff_t *_pos)
> {
> (*_pos)++;
> return key_user_next((struct rb_node *) v);
> -
> }
>
> static void proc_key_users_stop(struct seq_file *p, void *v)
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-08-04 18:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-04 14:55 [PATCH 1/6] KEYS: Deal with dead-type keys appropriately David Howells
2009-08-04 14:55 ` [PATCH 2/6] KEYS: Allow keyctl_revoke() on keys that have SETATTR but not WRITE perm David Howells
2009-08-04 15:17 ` Serge E. Hallyn
2009-08-04 15:38 ` David Howells
2009-08-04 15:43 ` David Howells
2009-08-04 14:55 ` [PATCH 3/6] KEYS: Flag dead keys to induce EKEYREVOKED David Howells
2009-08-04 18:22 ` Serge E. Hallyn
2009-08-04 14:55 ` [PATCH 4/6] KEYS: Add garbage collection for dead, revoked and expired keys David Howells
2009-08-04 18:43 ` Serge E. Hallyn
2009-08-04 20:30 ` David Howells
2009-08-04 21:01 ` Serge E. Hallyn
2009-08-04 22:00 ` David Howells
2009-08-04 22:33 ` Serge E. Hallyn
2009-08-04 14:55 ` [PATCH 5/6] KEYS: Make /proc/keys use keyid not numread as file position David Howells
2009-08-04 14:55 ` [PATCH 6/6] KEYS: Do some whitespace cleanups David Howells
2009-08-04 18:46 ` Serge E. Hallyn [this message]
2009-08-04 18:16 ` [PATCH 1/6] KEYS: Deal with dead-type keys appropriately Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090804184618.GD8442@us.ibm.com \
--to=serue@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox