From: "Serge E. Hallyn" <serue@us.ibm.com>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@osdl.org, akpm@linux-foundation.org, jmorris@namei.org,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH 4/6] KEYS: Add garbage collection for dead, revoked and expired keys.
Date: Tue, 4 Aug 2009 16:01:01 -0500 [thread overview]
Message-ID: <20090804210101.GB13499@us.ibm.com> (raw)
In-Reply-To: <5007.1249417827@redhat.com>
Quoting David Howells (dhowells@redhat.com):
> Serge E. Hallyn <serue@us.ibm.com> wrote:
>
> > These two lines (repeated below) beg for a helper?
>
> Yeah... Seems reasonable.
>
> > Can this happen? This implies that the number of live keys
> > went up, but we're under keyring->sem?
>
> An expired key can be updated back to life:
>
> [root@andromeda ~]# keyctl add user a a @s
> 619170185
> [root@andromeda ~]# keyctl timeout 619170185 5
> [root@andromeda ~]# keyctl show
> Session Keyring
> -3 --alswrv 0 0 keyring: _ses
> 627083299 --alswrv 0 -1 \_ keyring: _uid.0
> 619170185 --alswrv 0 0 \_ user: a
> [root@andromeda ~]# keyctl show
> Session Keyring
> -3 --alswrv 0 0 keyring: _ses
> 627083299 --alswrv 0 -1 \_ keyring: _uid.0
> 619170185: key inaccessible (Key has expired)
> [root@andromeda ~]# keyctl add user a a @s
> 619170185
> [root@andromeda ~]# keyctl show
> Session Keyring
> -3 --alswrv 0 0 keyring: _ses
> 627083299 --alswrv 0 -1 \_ keyring: _uid.0
> 619170185 --alswrv 0 0 \_ user: a
This won't require keyring->sem?
> > > + .data = &key_gc_delay,
> >
> > I see where this variable is defined at top of the patch, but
> > I don't see where it is actually used?
>
> Bah! I forgot to add gc.c to the mix. Sorry about that.
>
> David
next prev parent reply other threads:[~2009-08-04 21:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-04 14:55 [PATCH 1/6] KEYS: Deal with dead-type keys appropriately David Howells
2009-08-04 14:55 ` [PATCH 2/6] KEYS: Allow keyctl_revoke() on keys that have SETATTR but not WRITE perm David Howells
2009-08-04 15:17 ` Serge E. Hallyn
2009-08-04 15:38 ` David Howells
2009-08-04 15:43 ` David Howells
2009-08-04 14:55 ` [PATCH 3/6] KEYS: Flag dead keys to induce EKEYREVOKED David Howells
2009-08-04 18:22 ` Serge E. Hallyn
2009-08-04 14:55 ` [PATCH 4/6] KEYS: Add garbage collection for dead, revoked and expired keys David Howells
2009-08-04 18:43 ` Serge E. Hallyn
2009-08-04 20:30 ` David Howells
2009-08-04 21:01 ` Serge E. Hallyn [this message]
2009-08-04 22:00 ` David Howells
2009-08-04 22:33 ` Serge E. Hallyn
2009-08-04 14:55 ` [PATCH 5/6] KEYS: Make /proc/keys use keyid not numread as file position David Howells
2009-08-04 14:55 ` [PATCH 6/6] KEYS: Do some whitespace cleanups David Howells
2009-08-04 18:46 ` Serge E. Hallyn
2009-08-04 18:16 ` [PATCH 1/6] KEYS: Deal with dead-type keys appropriately Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090804210101.GB13499@us.ibm.com \
--to=serue@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox