Re: mmotm 2009-08-04-14-22 uploaded (ummunotify)

[Randy Dunlap <randy.dunlap@oracle.com>]

On Tue, 04 Aug 2009 21:47:30 -0700 Roland Dreier wrote:

> Andrew, can you add this into the ummunotify patch, or add it on top or whatever?
> 
> Fix
> 
>     ummunotify.c:(.text+0x8f217): undefined reference to `__get_user_X'
> 
> when building for i386 -- get_user() can't handle u64 on all
> architectures, so just use copy_from_user().
> 
> Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
> Signed-off-by: Roland Dreier <rolandd@cisco.com>

Ack & thanks.


> ---
>  drivers/char/ummunotify.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/char/ummunotify.c b/drivers/char/ummunotify.c
> index 725fbb0..29de6ab 100644
> --- a/drivers/char/ummunotify.c
> +++ b/drivers/char/ummunotify.c
> @@ -453,7 +453,7 @@ static long ummunotify_unregister_region(struct ummunotify_file *priv,
>  	struct ummunotify_reg *reg;
>  	int ret = -EINVAL;
>  
> -	if (get_user(user_cookie, arg))
> +	if (copy_from_user(&user_cookie, arg, sizeof user_cookie))
>  		return -EFAULT;
>  
>  	spin_lock_irq(&priv->lock);
> --

---
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/