public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Amerigo Wang <amwang@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: tony.luck@intel.com, linux-ia64@vger.kernel.org,
	Neil Horman <nhorman@redhat.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Amerigo Wang <amwang@redhat.com>,
	akpm@linux-foundation.org, Ingo Molnar <mingo@elte.hu>,
	Anton Vorontsov <avorontsov@ru.mvista.com>
Subject: [Patch 2/7] x86: implement crashkernel=auto
Date: Wed, 5 Aug 2009 07:19:22 -0400	[thread overview]
Message-ID: <20090805112142.6552.18373.sendpatchset@localhost.localdomain> (raw)
In-Reply-To: <20090805112123.6552.73574.sendpatchset@localhost.localdomain>


Implement "crashkernel=auto" for x86 first, other arch will be added in the
following patches.

Signed-off-by: WANG Cong <amwang@redhat.com>

---
Index: linux-2.6/kernel/kexec.c
===================================================================
--- linux-2.6.orig/kernel/kexec.c
+++ linux-2.6/kernel/kexec.c
@@ -37,6 +37,7 @@
 #include <asm/io.h>
 #include <asm/system.h>
 #include <asm/sections.h>
+#include <asm/setup.h>
 
 /* Per cpu memory for storing cpu states in case of system crash. */
 note_buf_t* crash_notes;
@@ -1297,6 +1298,38 @@ int __init parse_crashkernel(char 		 *cm
 
 	ck_cmdline += 12; /* strlen("crashkernel=") */
 
+#ifdef CONFIG_KEXEC_AUTO_RESERVE
+	if (strncmp(ck_cmdline, "auto", 4) == 0) {
+		unsigned long long size;
+		char tmp[32];
+
+		size = arch_default_crash_size(system_ram);
+		if (size != 0) {
+			*crash_size = size;
+			*crash_base = arch_default_crash_base();
+			size = scnprintf(tmp, sizeof(tmp), "%luM@%luM",
+					(unsigned long)(*crash_size)>>20,
+					(unsigned long)(*crash_base)>>20);
+			/* size can't be <= 4. */
+			if (likely((size - 4 + strlen(cmdline))
+					< COMMAND_LINE_SIZE - 1)) {
+				memmove(ck_cmdline + size, ck_cmdline + 4,
+					strlen(cmdline) - (ck_cmdline + 4 - cmdline) + 1);
+				memcpy(ck_cmdline, tmp, size);
+			}
+			return 0;
+		} else {
+			/*
+			 * We can't reserve memory auotmatcally,
+			 * remove "crashkernel=" from cmdline.
+			 */
+			ck_cmdline += 4; /* strlen("auto") */
+			memmove(ck_cmdline - 16, ck_cmdline,
+				strlen(cmdline) - (ck_cmdline - cmdline) + 1);
+			return -ENOMEM;
+		}
+	}
+#endif
 	/*
 	 * if the commandline contains a ':', then that's the extended
 	 * syntax -- if not, it must be the classic syntax
Index: linux-2.6/arch/x86/include/asm/kexec.h
===================================================================
--- linux-2.6.orig/arch/x86/include/asm/kexec.h
+++ linux-2.6/arch/x86/include/asm/kexec.h
@@ -61,6 +61,29 @@
 # define KEXEC_ARCH KEXEC_ARCH_X86_64
 #endif
 
+#ifdef CONFIG_KEXEC_AUTO_RESERVE
+#ifndef KEXEC_AUTO_RESERVED_SIZE
+#define KEXEC_AUTO_RESERVED_SIZE 1ULL<<27 /* 128M */
+#endif
+#ifndef KEXEC_AUTO_THRESHOLD
+#define KEXEC_AUTO_THRESHOLD 1ULL<<32 /* 4G */
+#endif
+static inline
+unsigned long long arch_default_crash_size(unsigned long long total_size)
+{
+	if (total_size < KEXEC_AUTO_THRESHOLD)
+		return 0;
+	else
+		return KEXEC_AUTO_RESERVED_SIZE;
+}
+static inline
+unsigned long long arch_default_crash_base(void)
+{
+	/* On x86, 0 means find the base address automatically. */
+	return 0;
+}
+#endif
+
 /*
  * CPU does not save ss and sp on stack if execution is already
  * running in kernel mode at the time of NMI occurrence. This code

  parent reply	other threads:[~2009-08-05 11:26 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-05 11:19 [Patch 0/7] Implement crashkernel=auto Amerigo Wang
2009-08-05 11:19 ` [Patch 1/7] x86: add CONFIG_KEXEC_AUTO_RESERVE Amerigo Wang
2009-08-05 13:41   ` Neil Horman
2009-08-05 14:45   ` Andi Kleen
2009-08-05 20:07     ` Eric W. Biederman
2009-08-06  1:55     ` Amerigo Wang
2009-08-06  7:15       ` Andi Kleen
2009-08-06  7:44         ` Amerigo Wang
2009-08-06  7:56         ` Amerigo Wang
2009-08-05 11:19 ` Amerigo Wang [this message]
2009-08-05 13:43   ` [Patch 2/7] x86: implement crashkernel=auto Neil Horman
2009-08-06  1:45     ` Amerigo Wang
2009-08-05 22:51   ` Yu, Fenghua
2009-08-06  1:56     ` Amerigo Wang
2009-08-05 11:19 ` [Patch 3/7] ia64: add CONFIG_KEXEC_AUTO_RESERVE Amerigo Wang
2009-08-05 13:49   ` Neil Horman
2009-08-05 11:19 ` [Patch 4/7] ia64: implement crashkernel=auto Amerigo Wang
2009-08-05 13:46   ` Neil Horman
2009-08-05 11:19 ` [Patch 5/7] powerpc: add CONFIG_KEXEC_AUTO_RESERVE Amerigo Wang
2009-08-05 13:49   ` Neil Horman
2009-08-05 11:20 ` [Patch 6/7] powerpc: implement crashkernel=auto Amerigo Wang
2009-08-05 13:50   ` Neil Horman
2009-08-05 11:20 ` [Patch 7/7] doc: update the kdump document Amerigo Wang
2009-08-05 13:33 ` [Patch 0/7] Implement crashkernel=auto Eric W. Biederman
2009-08-05 14:04   ` Neil Horman
2009-08-05 22:57     ` Eric W. Biederman
2009-08-06  2:05       ` Amerigo Wang
2009-08-06  2:47         ` Eric W. Biederman
2009-08-06  3:39           ` Amerigo Wang
2009-08-06  3:51             ` Eric W. Biederman
2009-08-06  5:57               ` Amerigo Wang
2009-08-06  6:14                 ` Eric W. Biederman
2009-08-06  6:37                   ` Amerigo Wang
2009-08-06  8:35                     ` Eric W. Biederman
2009-08-06  8:47                       ` Eric W. Biederman
2009-08-06  9:04                         ` Amerigo Wang
2009-08-07 19:13                         ` Bernhard Walle
2009-08-06  9:11                       ` Amerigo Wang
2009-08-07 19:50                         ` Eric W. Biederman
2009-08-07 21:03                           ` Andi Kleen
2009-08-07 21:26                             ` Bernhard Walle
2009-08-07 22:06                             ` Eric W. Biederman
2009-08-07 21:31                           ` Bernhard Walle
2009-08-07 22:16                             ` Eric W. Biederman
2009-08-10  3:11                           ` Amerigo Wang
2009-08-06  1:39   ` Amerigo Wang
  -- strict thread matches above, loose matches on Subject: below --
2009-08-06  6:19 [Patch 0/7] V2 " Amerigo Wang
2009-08-06  6:19 ` [Patch 2/7] x86: implement crashkernel=auto Amerigo Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090805112142.6552.18373.sendpatchset@localhost.localdomain \
    --to=amwang@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=avorontsov@ru.mvista.com \
    --cc=ebiederm@xmission.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=nhorman@redhat.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox