Re: [PATCH] [16/19] HWPOISON: Enable .remove_error_page for migration aware file systems

Christoph Hellwig
2009-08-05T11:12:48Z

On Wed, Aug 05, 2009 at 11:36:43AM +0200, Andi Kleen wrote:
>
> Enable removing of corrupted pages through truncation
> for a bunch of file systems: ext*, xfs, gfs2, ocfs2, ntfs
> These should cover most server needs.
>
> I chose the set of migration aware file systems for this
> for now, assuming they have been especially audited.
> But in general it should be safe for all file systems
> on the data area that support read/write and truncate.
>
> Caveat: the hardware error handler does not take i_mutex
> for now before calling the truncate function. Is that ok?

It will probably need locking, e.g. the iolock in XFS. I'll
need to take a look at the actual implementation of
generic_error_remove_page to make sense of this.

Is there any way for us to test this functionality without introducing
real hardware problems?