Re: [PATCH] [16/19] HWPOISON: Enable .remove_error_page for migration aware file systems

Andi Kleen
2009-08-11T13:10:38Z

On Tue, Aug 11, 2009 at 12:48:36PM +0900, Hidehiro Kawai wrote:
> Wu Fengguang wrote:
>
> >>However, we have a way to avoid this kind of data corruption at
> >>least for ext3. If we mount an ext3 filesystem with data=ordered
> >>and data_err=abort, all I/O errors on file data block belonging to
> >>the committing transaction are checked. When I/O error is found,
> >>abort journaling and remount the filesystem with read-only to
> >>prevent further updates. This kind of feature is very important
> >>for mission critical systems.
> >
> > Agreed. We also set PG_error, which should be enough to trigger such
> > remount?
>
> ext3 doesn't check PG_error. Maybe we need to do:

When we truncate the page it's gone so there's no page to set PG_error
on.

-Andi
--
ak@linux.intel.com -- Speaking for myself only.