From: Christoph Hellwig <hch@lst.de>
To: Greg Ungerer <gerg@snapgear.com>
Cc: Christoph Hellwig <hch@lst.de>,
gerg@uclinux.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] m68knommu: convert to asm-generic/hardirq.h
Date: Wed, 5 Aug 2009 17:08:56 +0200 [thread overview]
Message-ID: <20090805150856.GA5535@lst.de> (raw)
In-Reply-To: <4A791067.3030405@snapgear.com>
On Wed, Aug 05, 2009 at 02:53:59PM +1000, Greg Ungerer wrote:
> Hi Christoph,
>
> Christoph Hellwig wrote:
> >Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Compile testing revealed:
>
> LD vmlinux
> kernel/built-in.o: In function `ack_bad':
> handle.c:(.text+0x215f6): undefined reference to `ack_bad_irq'
> kernel/built-in.o: In function `handle_bad_irq':
> (.text+0x219dc): undefined reference to `ack_bad_irq'
> make[2]: *** [vmlinux] Error 1
>
>
> I did this to fix it:
>
> --- a/arch/m68k/include/asm/hardirq_no.h
> +++ b/arch/m68k/include/asm/hardirq_no.h
> @@ -14,9 +14,6 @@
> # error HARDIRQ_BITS is too low!
> #endif
>
> -void ack_bad_irq(unsigned int irq);
> -#define ack_bad_irq ack_bad_irq
> -
Sorry. Yeah, m68knommu should use the default ack_bad_irq.
prev parent reply other threads:[~2009-08-05 15:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-04 14:52 [PATCH] m68knommu: convert to asm-generic/hardirq.h Christoph Hellwig
2009-08-05 2:06 ` Greg Ungerer
2009-08-05 4:53 ` Greg Ungerer
2009-08-05 15:08 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090805150856.GA5535@lst.de \
--to=hch@lst.de \
--cc=gerg@snapgear.com \
--cc=gerg@uclinux.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox