From: Christoph Hellwig <hch@infradead.org>
To: Ramon de Carvalho Valle <ramon@risesecurity.org>
Cc: Eric Sandeen <sandeen@sandeen.net>,
Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, mszeredi@novell.com, hch@lst.de,
xfs@oss.sgi.com
Subject: Re: [PATCH 1/1] XFS: xfs_iformat realtime device target pointer check
Date: Wed, 5 Aug 2009 11:17:50 -0400 [thread overview]
Message-ID: <20090805151750.GA16080@infradead.org> (raw)
In-Reply-To: <1249411898.7576.19.camel@logos>
On Tue, Aug 04, 2009 at 03:51:38PM -0300, Ramon de Carvalho Valle wrote:
> The xfs_iformat function does not check if the realtime device target pointer
> is valid when the XFS_DIFLAG_REALTIME flag is set on the ondisk inode
> structure.
Same as Eric I don't think there's much of a point renumbering the error
cases. Instead I'll do another patch with a couple of cleanups in this
function replacing all the numbers with short alphabetic tags.
I don't really see the point of printing the flags either, if we have
this bit flipped it's pretty clear that we had random corruption of this
dinode.
next prev parent reply other threads:[~2009-08-05 15:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-03 20:03 [PATCH 1/1] XFS: __xfs_get_blocks check pointer to the target device Ramon de Carvalho Valle
2009-08-03 21:49 ` Christoph Hellwig
2009-08-04 2:00 ` Ramon de Carvalho Valle
2009-08-04 14:31 ` Christoph Hellwig
2009-08-04 16:25 ` Eric Sandeen
2009-08-04 18:50 ` Ramon de Carvalho Valle
2009-08-04 18:51 ` [PATCH 1/1] XFS: xfs_iformat realtime device target pointer check Ramon de Carvalho Valle
2009-08-04 19:11 ` Eric Sandeen
2009-08-05 3:55 ` Ramon de Carvalho Valle
2009-08-05 4:15 ` Eric Sandeen
2009-08-05 13:21 ` Ramon de Carvalho Valle
2009-08-05 21:53 ` Felix Blyakher
2009-08-05 15:17 ` Christoph Hellwig [this message]
2009-08-05 16:34 ` Ramon de Carvalho Valle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090805151750.GA16080@infradead.org \
--to=hch@infradead.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mszeredi@novell.com \
--cc=ramon@risesecurity.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox