From: Frans Pop <elendil@planet.nl>
To: Daniel Mack <daniel@caiaq.de>
Cc: linux-kernel@vger.kernel.org, daniel@caiaq.de,
szabolcs.gyurko@tlt.hu, mreimer@vpop.net, cbou@mail.ru
Subject: Re: [PATCH 1/2] ds2760: switch to new dev_pm_ops
Date: Wed, 5 Aug 2009 16:57:47 +0200 [thread overview]
Message-ID: <200908051657.49810.elendil@planet.nl> (raw)
In-Reply-To: <1249476387-27325-1-git-send-email-daniel@caiaq.de>
Daniel Mack wrote:
> +static struct dev_pm_ops ds2760_battery_pm_ops = {
> + .suspend = ds2760_battery_suspend,
> + .resume = ds2760_battery_resume,
> +};
Just to make sure...
Have you followed the earlier discussions on dev_pm_ops conversions and
are you aware that if done like this the driver no longer supports
hibernation?
If omitting hibernation is intentional, it should probably be justified in
the commit log.
See http://lkml.org/lkml/2009/7/25/118 for background.
Same goes for your patch for w1_gpio of course.
Cheers,
FJP
next prev parent reply other threads:[~2009-08-05 14:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-05 12:46 [PATCH 1/2] ds2760: switch to new dev_pm_ops Daniel Mack
2009-08-05 14:57 ` Frans Pop [this message]
2009-08-05 15:41 ` Rafael J. Wysocki
2009-08-05 16:58 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908051657.49810.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=cbou@mail.ru \
--cc=daniel@caiaq.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mreimer@vpop.net \
--cc=szabolcs.gyurko@tlt.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox