From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Frans Pop <elendil@planet.nl>, Daniel Mack <daniel@caiaq.de>
Cc: linux-kernel@vger.kernel.org, szabolcs.gyurko@tlt.hu,
mreimer@vpop.net, cbou@mail.ru,
pm list <linux-pm@lists.linux-foundation.org>
Subject: Re: [PATCH 1/2] ds2760: switch to new dev_pm_ops
Date: Wed, 5 Aug 2009 17:41:57 +0200 [thread overview]
Message-ID: <200908051741.58698.rjw@sisk.pl> (raw)
In-Reply-To: <200908051657.49810.elendil@planet.nl>
On Wednesday 05 August 2009, Frans Pop wrote:
> Daniel Mack wrote:
> > +static struct dev_pm_ops ds2760_battery_pm_ops = {
> > + .suspend = ds2760_battery_suspend,
> > + .resume = ds2760_battery_resume,
> > +};
>
> Just to make sure...
>
> Have you followed the earlier discussions on dev_pm_ops conversions and
> are you aware that if done like this the driver no longer supports
> hibernation?
>
> If omitting hibernation is intentional, it should probably be justified in
> the commit log.
>
> See http://lkml.org/lkml/2009/7/25/118 for background.
>
> Same goes for your patch for w1_gpio of course.
Frans, thanks for your vigilance. :-)
Daniel and everyone doing dev_pm_ops conversions or any other PM-related
things, please CC your patches to linux-pm@lists.linux-foundation.org .
Best,
Rafael
next prev parent reply other threads:[~2009-08-05 15:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-05 12:46 [PATCH 1/2] ds2760: switch to new dev_pm_ops Daniel Mack
2009-08-05 14:57 ` Frans Pop
2009-08-05 15:41 ` Rafael J. Wysocki [this message]
2009-08-05 16:58 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908051741.58698.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=cbou@mail.ru \
--cc=daniel@caiaq.de \
--cc=elendil@planet.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mreimer@vpop.net \
--cc=szabolcs.gyurko@tlt.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox