From: Daniel Mack <daniel@caiaq.de>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux-kernel@vger.kernel.org,
linux-pm@lists.linux-foundation.org,
Ville Syrjala <syrjala@sci.fi>,
Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Subject: Re: [PATCH 1/5] w1_gpio: switch to new dev_pm_ops
Date: Wed, 5 Aug 2009 20:45:00 +0200 [thread overview]
Message-ID: <20090805184500.GO13236@buzzloop.caiaq.de> (raw)
In-Reply-To: <200908052044.02103.rjw@sisk.pl>
On Wed, Aug 05, 2009 at 08:44:01PM +0200, Rafael J. Wysocki wrote:
> > +static struct dev_pm_ops w1_gpio_pm_ops = {
> > + .suspend = w1_gpio_suspend,
> > + .freeze = w1_gpio_suspend,
> > + .resume = w1_gpio_resume,
> > + .thaw = w1_gpio_resume,
>
> You need
>
> + .poweroff = w1_gpio_suspend,
> + .restore = w1_gpio_resume,
>
> in addition to these, which seems to be the case with the rest of the patches
> too.
>
> If you wait for a little while with the patchset, we're going to have a
> convenience macro for defining such 'standard' dev_pm_ops objects.
Ok, fine. Letting them all point the same function looks somwhat hackish
to me, so I'll wait for that macro. Let me know when that has arrived :)
Daniel
prev parent reply other threads:[~2009-08-05 18:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-05 18:29 [PATCH 1/5] w1_gpio: switch to new dev_pm_ops Daniel Mack
2009-08-05 18:29 ` [PATCH 2/5] pda-power: " Daniel Mack
2009-08-05 18:29 ` [PATCH 3/5] ds2760: " Daniel Mack
2009-08-05 18:29 ` [PATCH 4/5] input: gpio-keys: " Daniel Mack
2009-08-05 18:29 ` [PATCH 5/5] net: smsc911x: " Daniel Mack
2009-08-06 3:29 ` David Miller
2009-08-06 11:53 ` Steve.Glendinning
2009-08-06 20:26 ` David Miller
2009-08-05 20:15 ` [PATCH 4/5] input: gpio-keys: " pHilipp Zabel
2009-08-05 22:33 ` Daniel Mack
2009-08-06 0:51 ` [linux-pm] " Rafael J. Wysocki
2009-08-06 12:59 ` Daniel Mack
2009-08-06 15:19 ` Rafael J. Wysocki
2009-08-07 13:39 ` pHilipp Zabel
2009-08-05 19:49 ` [PATCH 2/5] pda-power: " Frans Pop
2009-08-05 22:29 ` Daniel Mack
2009-08-06 11:52 ` pHilipp Zabel
2009-08-06 12:56 ` Daniel Mack
2009-08-07 13:35 ` pHilipp Zabel
2009-09-04 16:34 ` Anton Vorontsov
2009-08-05 18:44 ` [PATCH 1/5] w1_gpio: " Rafael J. Wysocki
2009-08-05 18:45 ` Daniel Mack [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090805184500.GO13236@buzzloop.caiaq.de \
--to=daniel@caiaq.de \
--cc=johnpol@2ka.mipt.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
--cc=syrjala@sci.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox