From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Frans Pop <elendil@planet.nl>, pHilipp Zabel <philipp.zabel@gmail.com>
Cc: albin.tonnerre@free-electrons.com, dmitry.torokhov@gmail.com,
linux-kernel@vger.kernel.org,
linux-pm@lists.linux-foundation.org, daniel@caiaq.de
Subject: Re: [PATCH] PM: Add convenience macro to make switching to dev_pm_ops less error-prone
Date: Wed, 5 Aug 2009 23:30:07 +0200 [thread overview]
Message-ID: <200908052330.08452.rjw@sisk.pl> (raw)
In-Reply-To: <200908052222.31707.elendil@planet.nl>
On Wednesday 05 August 2009, Frans Pop wrote:
> Rafael J. Wysocki wrote:
>
> > +#define SIMPLE_DEV_PM_OPS(name, suspend_fn, resume_fn) \
> > +struct dev_pm_ops name = { \
> > + .suspend = suspend_fn, \
> > + .resume = resume_fn, \
> > + .freeze = suspend_fn, \
> > + .thaw = resume_fn, \
> > + .poweroff = suspend_fn, \
> > + .resume = resume_fn, \
>
> That defines .resume twice. Guess the last should be restore.
Yes, thanks to you and Philipp for noticing that and sorry for the mistake.
Rafael
next prev parent reply other threads:[~2009-08-05 21:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-03 16:33 [PATCH V2] au1xmmc: dev_pm_ops conversion Albin Tonnerre
2009-08-03 19:23 ` Rafael J. Wysocki
2009-08-04 9:36 ` [PATCH] Add SIMPLE_PM_OPS: make switching to dev_pm_ops less error-prone Albin Tonnerre
2009-08-05 4:55 ` Dmitry Torokhov
2009-08-05 9:37 ` Albin Tonnerre
2009-08-05 18:47 ` Rafael J. Wysocki
2009-08-05 20:05 ` [PATCH] PM: Add convenience macro to " Rafael J. Wysocki
2009-08-05 20:17 ` pHilipp Zabel
2009-08-05 20:22 ` Frans Pop
2009-08-05 21:30 ` Rafael J. Wysocki [this message]
2009-08-06 8:51 ` Daniel Mack
2009-08-06 12:16 ` Rafael J. Wysocki
2009-08-06 13:10 ` Magnus Damm
2009-08-06 15:14 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908052330.08452.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=albin.tonnerre@free-electrons.com \
--cc=daniel@caiaq.de \
--cc=dmitry.torokhov@gmail.com \
--cc=elendil@planet.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox