From: Ingo Molnar <mingo@elte.hu>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
Li Zefan <lizf@cn.fujitsu.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [GIT PULL] tracing: Various cleanups for 2.6.32, v2
Date: Thu, 6 Aug 2009 14:24:42 +0200 [thread overview]
Message-ID: <20090806122442.GA15314@elte.hu> (raw)
In-Reply-To: <1249540058-5528-1-git-send-email-fweisbec@gmail.com>
* Frederic Weisbecker <fweisbec@gmail.com> wrote:
> Ingo,
>
> This new shot fixes the build errors you've reported after testing
> the first version. The fact is that the trace_function() helper is
> not only used by the function tracer but also by various other
> tracing callsites.
>
> Instead of keeping it in the function tracer file and paint it
> with messy #ifdefs, I think it's better to keep it in the generic
> trace.c because it's actually a general helper for various
> tracers.
>
> I've then zapped the trace_function() moving in the third patch
> but kept one of its side effects necessary for the function graph
> tracer helpers moving: the ftrace_cpu_disabled var globalizing.
>
> This series also gained a new patch that shuts down a warning in
> trace_events.c
>
> Thanks,
> Frederic.
>
>
>
> The following changes since commit 1f9963cbb0280e0cd554161e00f1a0eeddbf1ae1:
> Li Zefan (1):
> tracing/filters: improve subsystem filter
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing.git tracing/core
>
> Frederic Weisbecker (6):
> tracing/function-graph-tracer: Drop the useless nmi protection
> tracing/core: Turn ftrace_cpu_disabled into a global var
> tracing/core: Make the stack entry helpers global
> tracing: Move sched event insertion helpers in the sched switch tracer file
> tracing/function-graph-tracer: Move graph event insertion helpers in the graph tracer file
> tracing/events: Only define remove_subsystem_dir() if CONFIG_MODULES
>
> Lai Jiangshan (1):
> tracing: Simplify print_graph_cpu()
>
> arch/x86/kernel/ftrace.c | 4 -
> kernel/trace/trace.c | 192 ++--------------------------------
> kernel/trace/trace.h | 30 +++++-
> kernel/trace/trace_events.c | 52 +++++-----
> kernel/trace/trace_functions_graph.c | 152 ++++++++++++++++++++++-----
> kernel/trace/trace_sched_switch.c | 57 ++++++++++
> kernel/trace/trace_selftest.c | 1 +
> 7 files changed, 243 insertions(+), 245 deletions(-)
Pulled, thanks Frederic!
Ingo
next prev parent reply other threads:[~2009-08-06 12:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-29 17:13 [GIT PULL] tracing: Various cleanups for 2.6.32 Frederic Weisbecker
2009-07-29 17:13 ` [PATCH 1/6] tracing: Simplify print_graph_cpu() Frederic Weisbecker
2009-07-29 17:13 ` [PATCH 2/6] tracing/function-graph-tracer: Drop the useless nmi protection Frederic Weisbecker
2009-07-29 17:13 ` [PATCH 3/6] tracing/function-tracer: Move trace_function() in the function tracer file Frederic Weisbecker
2009-07-29 17:13 ` [PATCH 4/6] tracing/core: Make the stack entry helpers global Frederic Weisbecker
2009-07-29 17:13 ` [PATCH 5/6] tracing: Move sched event insertion helpers in the sched switch tracer file Frederic Weisbecker
2009-07-29 17:13 ` [PATCH 6/6] tracing/function-graph-tracer: Move graph event insertion helpers in the graph " Frederic Weisbecker
2009-07-30 1:48 ` [GIT PULL] tracing: Various cleanups for 2.6.32 Li Zefan
2009-07-30 13:00 ` Steven Rostedt
2009-08-02 19:34 ` Ingo Molnar
2009-08-02 19:53 ` Ingo Molnar
2009-08-03 1:18 ` Frédéric Weisbecker
2009-08-06 6:27 ` [GIT PULL] tracing: Various cleanups for 2.6.32, v2 Frederic Weisbecker
2009-08-06 12:24 ` Ingo Molnar [this message]
2009-08-06 6:27 ` [PATCH 1/7] tracing: Simplify print_graph_cpu() Frederic Weisbecker
2009-08-06 6:27 ` [PATCH 2/7] tracing/function-graph-tracer: Drop the useless nmi protection Frederic Weisbecker
2009-08-06 6:27 ` [PATCH 3/7] tracing/core: Turn ftrace_cpu_disabled into a global var Frederic Weisbecker
2009-08-06 6:27 ` [PATCH 4/7] tracing/core: Make the stack entry helpers global Frederic Weisbecker
2009-08-06 6:27 ` [PATCH 5/7] tracing: Move sched event insertion helpers in the sched switch tracer file Frederic Weisbecker
2009-08-06 6:27 ` [PATCH 6/7] tracing/function-graph-tracer: Move graph event insertion helpers in the graph " Frederic Weisbecker
2009-08-06 6:27 ` [PATCH 7/7] tracing/events: Only define remove_subsystem_dir() if CONFIG_MODULES Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090806122442.GA15314@elte.hu \
--to=mingo@elte.hu \
--cc=fweisbec@gmail.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox