public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* net/r8169.c: harmless (?) dupe
@ 2009-08-06 11:17 Vincent Pelletier
  0 siblings, 0 replies; only message in thread
From: Vincent Pelletier @ 2009-08-06 11:17 UTC (permalink / raw)
  To: linux-kernel

Hi.

I was searching for rtl8102 support state in the kernel, and reading the 
commit[1] adding support I saw this:

+#define R810X_CPCMD_QUIRK_MASK (\
+       EnableBist | \
+       Mac_dbgo_oe | \
+       Force_half_dup | \
+       Force_half_dup | \   <- dupe
+       Force_txflow_en | \
+       Cxpl_dbg_sel | \

If it is harmless by itself, wouldn't it indicate a missing Force_rxflow_en 
(as in R8168_CPCMD_QUIRK_MASK) ?
I don't have the card yet, so this is no bug report, just wondering.

[1] 2857ffb7b8913ef713533ac5783abd70a20529e4

PS: Please CC me when answering, I'm not subscribed.
-- 
Vincent Pelletier

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-08-06 11:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-06 11:17 net/r8169.c: harmless (?) dupe Vincent Pelletier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox