public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andreas Herrmann <andreas.herrmann3@amd.com>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org,
	Borislav Petkov <borislav.petkov@amd.com>,
	Brice Goglin <Brice.Goglin@inria.fr>
Subject: [PATCH] x86, topology: Swap semantic of core_siblings and cpu_node_siblings
Date: Thu, 6 Aug 2009 19:29:55 +0200	[thread overview]
Message-ID: <20090806172955.GF7198@alberich.amd.com> (raw)
In-Reply-To: <20090805154402.GA6520@alberich.amd.com>

Brice Goglin suggested to use the following semantic for
CPU topology information

  Level        | Set of CPUs
 --------------|---------------
  phys_package | cpu_node_siblings
  cpu_node     | core_siblings
  core         | thread_siblings
  thread       | one CPU

Done that.

CC: Brice Goglin <Brice.Goglin@inria.fr>
Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
---
 arch/x86/include/asm/topology.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Patch is on top of the 5 previous patches.
Documentation update will follow.

Regards,
Andreas


diff --git a/arch/x86/include/asm/topology.h b/arch/x86/include/asm/topology.h
index 9eddb69..d53ef91 100644
--- a/arch/x86/include/asm/topology.h
+++ b/arch/x86/include/asm/topology.h
@@ -188,10 +188,10 @@ extern const struct cpumask *cpu_coregroup_mask(int cpu);
 #ifdef ENABLE_TOPO_DEFINES
 #define topology_physical_package_id(cpu)	(cpu_data(cpu).phys_proc_id)
 #define topology_core_id(cpu)			(cpu_data(cpu).cpu_core_id)
-#define topology_core_cpumask(cpu)		(per_cpu(cpu_core_map, cpu))
+#define topology_core_cpumask(cpu)		(per_cpu(cpu_node_map, cpu))
 #define topology_thread_cpumask(cpu)		(per_cpu(cpu_sibling_map, cpu))
 #define topology_cpu_node_id(cpu)		(cpu_data(cpu).cpu_node_id)
-#define topology_cpu_node_cpumask(cpu)		(per_cpu(cpu_node_map, cpu))
+#define topology_cpu_node_cpumask(cpu)		(per_cpu(cpu_core_map, cpu))
 
 /* indicates that pointers to the topology cpumask_t maps are valid */
 #define arch_provides_topology_pointers		yes
-- 
1.6.3.3




  parent reply	other threads:[~2009-08-06 17:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-05 15:44 [PATCH 0/5 v4] x86: Adapt CPU topology detection for AMD Magny-Cours Andreas Herrmann
2009-08-05 15:46 ` [PATCH 1/5] topology: Introduce cpu_node information for multi-node processors Andreas Herrmann
2009-08-05 15:48 ` [PATCH 2/5] x86: Provide CPU topology " Andreas Herrmann
2009-08-06  8:30   ` Stephen Rothwell
2009-08-06 16:15     ` Andreas Herrmann
2009-08-06 17:44       ` [PATCH] x86, smpboot: use zalloc_cpumask_var instead of alloc/clear Andreas Herrmann
2009-08-05 15:49 ` [PATCH 3/5] x86: Add cpu_node topology detection for AMD Magny-Cours Andreas Herrmann
2009-08-05 15:50 ` [PATCH 4/5] x86, cacheinfo: Fixup L3 cache information for AMD multi-node processors Andreas Herrmann
2009-08-05 15:51 ` [PATCH 5/5] x86, mcheck: Make use of cpu_node_mask instead of cpu_core_mask Andreas Herrmann
2009-08-05 20:23 ` [PATCH 0/5 v4] x86: Adapt CPU topology detection for AMD Magny-Cours Brice Goglin
2009-08-06 10:42   ` Andreas Herrmann
2009-08-06 12:25     ` Brice Goglin
2009-08-06 16:08       ` Andreas Herrmann
2009-08-06 17:29 ` Andreas Herrmann [this message]
2009-08-06 18:24   ` [PATCH] topology: Update CPU topology documentation Andreas Herrmann
2009-08-08 15:17 ` [PATCH 0/5 v4] x86: Adapt CPU topology detection for AMD Magny-Cours Ingo Molnar
2009-08-08 15:49   ` Brice Goglin
2009-08-21 10:34   ` Andreas Herrmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090806172955.GF7198@alberich.amd.com \
    --to=andreas.herrmann3@amd.com \
    --cc=Brice.Goglin@inria.fr \
    --cc=borislav.petkov@amd.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox