From: Christoph Hellwig <hch@lst.de>
To: Michal Simek <monstr@monstr.eu>
Cc: microblaze-uclinux@itee.uq.edu.au, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [microblaze-uclinux] [PATCH] microblaze: convert to asm-generic/hardirq.h
Date: Thu, 6 Aug 2009 23:00:38 +0200 [thread overview]
Message-ID: <20090806210038.GA5147@lst.de> (raw)
In-Reply-To: <4A7AEEEC.2040400@monstr.eu>
On Thu, Aug 06, 2009 at 04:55:40PM +0200, Michal Simek wrote:
> Hi Christoph,
>
> Can you please change your patch title?
> You are removing ack_bad_irq not convert to hardirq.h
>
> But anyway will be worth to remove it from other archs too.
Oh sorry, I copied the patch from various other architectures I touched
at the same time. I have been wading throug all architectures to
convert them to asm-generic/hardirq.h and the generic ack_bad_irq and
sent out lots of patches for it. A couple of architectures do count
bad irqs instead of just printing a message, but even those counters
could be unified. The only genirq architectecture that does something
weird in ack_bad_irq is mips.
--
Subject: microblaze: use the generic ack_bad_irq implementation
From: Christoph Hellwig <hch@lst.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: linux-2.6/arch/microblaze/include/asm/hardirq.h
===================================================================
--- linux-2.6.orig/arch/microblaze/include/asm/hardirq.h 2009-07-27 14:32:58.596148711 +0200
+++ linux-2.6/arch/microblaze/include/asm/hardirq.h 2009-07-27 14:56:30.691912378 +0200
@@ -12,8 +12,6 @@
/* should be defined in each interrupt controller driver */
extern unsigned int get_irq(struct pt_regs *regs);
-#define ack_bad_irq ack_bad_irq
-void ack_bad_irq(unsigned int irq);
#include <asm-generic/hardirq.h>
#endif /* _ASM_MICROBLAZE_HARDIRQ_H */
Index: linux-2.6/arch/microblaze/kernel/irq.c
===================================================================
--- linux-2.6.orig/arch/microblaze/kernel/irq.c 2009-07-27 14:53:45.847149312 +0200
+++ linux-2.6/arch/microblaze/kernel/irq.c 2009-07-27 14:56:37.121902184 +0200
@@ -30,15 +30,6 @@ unsigned int irq_of_parse_and_map(struct
}
EXPORT_SYMBOL_GPL(irq_of_parse_and_map);
-/*
- * 'what should we do if we get a hw irq event on an illegal vector'.
- * each architecture has to answer this themselves.
- */
-void ack_bad_irq(unsigned int irq)
-{
- printk(KERN_WARNING "unexpected IRQ trap at vector %02x\n", irq);
-}
-
static u32 concurrent_irq;
void do_IRQ(struct pt_regs *regs)
next prev parent reply other threads:[~2009-08-06 21:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-04 14:53 [PATCH] microblaze: convert to asm-generic/hardirq.h Christoph Hellwig
2009-08-06 14:55 ` [microblaze-uclinux] " Michal Simek
2009-08-06 21:00 ` Christoph Hellwig [this message]
2009-08-07 11:51 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090806210038.GA5147@lst.de \
--to=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=microblaze-uclinux@itee.uq.edu.au \
--cc=monstr@monstr.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox