From: Greg KH <greg@kroah.com>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: Alan Jenkins <sourcejedi.lkml@googlemail.com>,
linux-kernel@vger.kernel.org, Jan Blunck <jblunck@suse.de>,
gregkh@suse.de, Harald Hoyer <harald@redhat.com>,
Scott James Remnant <scott@ubuntu.com>
Subject: Re: [PATCH] Driver Core: devtmpfs - kernel-maintained tmpfs-based /dev
Date: Thu, 6 Aug 2009 17:27:48 -0700 [thread overview]
Message-ID: <20090807002748.GA30062@kroah.com> (raw)
In-Reply-To: <ac3eb2510908051719o61e1d42er750fe837c824bc0@mail.gmail.com>
On Thu, Aug 06, 2009 at 02:19:23AM +0200, Kay Sievers wrote:
> On Thu, Aug 6, 2009 at 02:06, Greg KH<greg@kroah.com> wrote:
> > On Wed, Aug 05, 2009 at 09:55:49PM +0100, Alan Jenkins wrote:
>
> >> > + err = vfs_mkdir(nd.path.dentry->d_inode,
> >> > + dentry, 0775);
> >>
> >> Is there a typo here? I think the mode should be 0755. 0755 is used
> >> below, and that does fit better with the 0600 mode for device nodes.
> >
> > Yeah, I think you are correct. Kay, any objection to me making this
> > change?
>
> No, sure no objection. It sounds right to use 0755.
> I was just waiting if more things to fix come up. :)
I've made this fix in the version in my tree now.
thanks,
greg k-h
next prev parent reply other threads:[~2009-08-07 0:33 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-05 17:15 [PATCH] Driver Core: devtmpfs - kernel-maintained tmpfs-based /dev Greg KH
2009-08-05 17:43 ` David Vrabel
2009-08-05 17:55 ` Greg KH
2009-08-05 18:20 ` Alan Cox
2009-08-05 18:28 ` Greg KH
2009-08-05 18:51 ` Greg KH
2009-08-06 15:46 ` Andi Kleen
2009-08-06 16:20 ` David Dillow
2009-08-06 17:10 ` Andi Kleen
2009-08-06 18:31 ` Greg KH
2009-08-07 15:47 ` Phil Turmel
2009-08-08 23:07 ` David Dillow
2009-08-10 15:39 ` Greg KH
2009-08-11 14:36 ` David Dillow
2009-08-11 14:55 ` Andi Kleen
2009-08-12 0:04 ` Marcel Holtmann
2009-08-12 0:25 ` David Dillow
2009-08-12 0:34 ` Greg KH
2009-08-12 4:31 ` Arjan van de Ven
2009-08-12 12:56 ` David Dillow
2009-08-12 13:44 ` Greg KH
2009-08-12 14:09 ` Arjan van de Ven
2009-08-12 15:25 ` Greg KH
2009-08-12 14:39 ` David Dillow
2009-08-12 15:26 ` Greg KH
2009-08-12 15:57 ` David Dillow
2009-08-12 7:31 ` Andi Kleen
2009-08-12 12:50 ` David Dillow
2009-08-12 14:07 ` Arjan van de Ven
2009-08-12 14:14 ` Andi Kleen
2009-08-10 9:04 ` Scott James Remnant
2009-08-06 17:06 ` Al Boldi
2009-08-06 17:15 ` Kay Sievers
2009-08-06 17:27 ` Al Boldi
2009-08-06 17:31 ` Kay Sievers
2009-08-06 18:36 ` Greg KH
2009-08-06 20:18 ` Al Boldi
2009-08-06 20:49 ` Greg KH
2009-08-07 4:03 ` Al Boldi
2009-08-07 4:25 ` Greg KH
2009-08-07 5:04 ` Al Boldi
2009-08-07 5:20 ` Greg KH
2009-08-07 12:49 ` Al Boldi
2009-08-07 15:13 ` Greg KH
2009-08-07 15:51 ` Chris Friesen
2009-08-07 16:06 ` Kay Sievers
2009-08-07 21:17 ` Al Boldi
2009-08-07 22:24 ` Greg KH
2009-08-08 9:14 ` Al Boldi
2009-08-08 17:11 ` Greg KH
2009-08-08 18:55 ` Al Boldi
2009-08-10 15:40 ` Greg KH
2009-08-11 3:48 ` Al Boldi
2009-08-11 4:04 ` Greg KH
2009-08-11 15:18 ` Al Boldi
2009-08-11 15:49 ` Greg KH
2009-08-11 16:04 ` Chris Friesen
2009-08-11 16:51 ` Greg KH
2009-08-12 4:25 ` Al Boldi
2009-08-10 9:01 ` Scott James Remnant
2009-08-10 12:05 ` Al Boldi
2009-08-10 12:39 ` Scott James Remnant
2009-08-10 9:22 ` Harald Hoyer
2009-08-08 22:19 ` Arjan van de Ven
2009-08-05 20:55 ` Alan Jenkins
2009-08-06 0:06 ` Greg KH
2009-08-06 0:19 ` Kay Sievers
2009-08-07 0:27 ` Greg KH [this message]
2009-08-09 12:09 ` Pavel Machek
2009-08-10 16:36 ` Greg KH
2009-08-10 15:54 ` Pavel Machek
2009-08-12 1:20 ` Kay Sievers
2009-08-12 21:33 ` Robert Schwebel
2009-08-12 22:08 ` Greg KH
2009-08-13 8:25 ` Xavier Bestel
2009-08-13 8:55 ` Robert Schwebel
2009-08-13 2:18 ` Ming Lei
2009-08-13 2:53 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090807002748.GA30062@kroah.com \
--to=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=harald@redhat.com \
--cc=jblunck@suse.de \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=scott@ubuntu.com \
--cc=sourcejedi.lkml@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox