From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756731AbZHGAdB (ORCPT ); Thu, 6 Aug 2009 20:33:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756266AbZHGAdA (ORCPT ); Thu, 6 Aug 2009 20:33:00 -0400 Received: from kroah.org ([198.145.64.141]:56204 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751712AbZHGAc7 (ORCPT ); Thu, 6 Aug 2009 20:32:59 -0400 Date: Thu, 6 Aug 2009 17:27:48 -0700 From: Greg KH To: Kay Sievers Cc: Alan Jenkins , linux-kernel@vger.kernel.org, Jan Blunck , gregkh@suse.de, Harald Hoyer , Scott James Remnant Subject: Re: [PATCH] Driver Core: devtmpfs - kernel-maintained tmpfs-based /dev Message-ID: <20090807002748.GA30062@kroah.com> References: <20090805171513.GA10443@kroah.com> <9b2b86520908051355o79699e99ke045b635c6b443ad@mail.gmail.com> <20090806000659.GA22754@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 06, 2009 at 02:19:23AM +0200, Kay Sievers wrote: > On Thu, Aug 6, 2009 at 02:06, Greg KH wrote: > > On Wed, Aug 05, 2009 at 09:55:49PM +0100, Alan Jenkins wrote: > > >> > +                   err = vfs_mkdir(nd.path.dentry->d_inode, > >> > +                                   dentry, 0775); > >> > >> Is there a typo here?  I think the mode should be 0755.   0755 is used > >> below, and that does fit better with the 0600 mode for device nodes. > > > > Yeah, I think you are correct.  Kay, any objection to me making this > > change? > > No, sure no objection. It sounds right to use 0755. > I was just waiting if more things to fix come up. :) I've made this fix in the version in my tree now. thanks, greg k-h