From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757015AbZHGDeu (ORCPT ); Thu, 6 Aug 2009 23:34:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756969AbZHGDet (ORCPT ); Thu, 6 Aug 2009 23:34:49 -0400 Received: from 124x34x33x190.ap124.ftth.ucom.ne.jp ([124.34.33.190]:36297 "EHLO master.linux-sh.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756949AbZHGDes (ORCPT ); Thu, 6 Aug 2009 23:34:48 -0400 Date: Fri, 7 Aug 2009 12:34:48 +0900 From: Paul Mundt To: Andrew Morton Cc: Randy Dunlap , linux-kernel@vger.kernel.org, Magnus Damm , David Woodhouse , linux-mtd@lists.infradead.org Subject: Re: mmotm 2009-08-06-00-30 uploaded (mtd) Message-ID: <20090807033448.GA32592@linux-sh.org> Mail-Followup-To: Paul Mundt , Andrew Morton , Randy Dunlap , linux-kernel@vger.kernel.org, Magnus Damm , David Woodhouse , linux-mtd@lists.infradead.org References: <200908060733.n767X6mN023120@imap1.linux-foundation.org> <20090806190233.6d4b4e28.randy.dunlap@oracle.com> <20090806192513.53f6488b.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090806192513.53f6488b.akpm@linux-foundation.org> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 06, 2009 at 07:25:13PM -0700, Andrew Morton wrote: > On Thu, 6 Aug 2009 19:02:33 -0700 Randy Dunlap wrote: > > > On Thu, 06 Aug 2009 00:33:06 -0700 akpm@linux-foundation.org wrote: > > > > > The mm-of-the-moment snapshot 2009-08-06-00-30 has been uploaded to > > > > > > http://userweb.kernel.org/~akpm/mmotm/ > > > > > > and will soon be available at > > > > > > git://git.zen-sources.org/zen/mmotm.git > > > > > > It contains the following patches against 2.6.31-rc5: > > > > > > > > drivers/built-in.o: In function `generic_onenand_remove': > > generic.c:(.devexit.text+0x1b8e): undefined reference to `del_mtd_partitions' > > > > config attached. > > Thanks. It's mtd-make-onenand-genericc-more-generic.patch. > Wow, I guess ARM people don't do randconfigs. --- [PATCH] mtd: onenand: select MTD_PARTITIONS. All of the onenand drivers depend on mtd partition support being compiled in, so just select it. Fixes up build breakage: drivers/built-in.o: In function `generic_onenand_remove': generic.c:(.devexit.text+0x80): undefined reference to `del_mtd_partitions' Reported-by: Randy Dunlap Signed-off-by: Paul Mundt --- drivers/mtd/onenand/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/onenand/Kconfig b/drivers/mtd/onenand/Kconfig index 2d6b7c1..a38f580 100644 --- a/drivers/mtd/onenand/Kconfig +++ b/drivers/mtd/onenand/Kconfig @@ -5,6 +5,7 @@ menuconfig MTD_ONENAND tristate "OneNAND Device Support" depends on MTD + select MTD_PARTITIONS help This enables support for accessing all type of OneNAND flash devices. For further information see @@ -65,7 +66,6 @@ config MTD_ONENAND_2X_PROGRAM config MTD_ONENAND_SIM tristate "OneNAND simulator support" - depends on MTD_PARTITIONS help The simulator may simulate various OneNAND flash chips for the OneNAND MTD layer.