Re: [PATCH 3/5] tty: handle VT specific compat ioctls in vt driver

Greg KH
2009-08-08T03:41:56Z

On Sat, Aug 08, 2009 at 03:03:36AM +0200, Frederic Weisbecker wrote:
> On Fri, Aug 07, 2009 at 05:41:56PM -0700, Greg KH wrote:
> > On Sat, Aug 08, 2009 at 02:34:53AM +0200, Frederic Weisbecker wrote:
> > > On Fri, Aug 07, 2009 at 02:02:11PM +0200, Arnd Bergmann wrote:
> > > > On Friday 07 August 2009, Frederic Weisbecker wrote:
> > > > > Ok. This looks like a nice series. A bkl pushdown that only goes down
> > > > > in one site among several others enlightens the understanding of what it
> > > > > is protecting (beside the nice fact it also burned three bkl callsites :-)
> > > >
> > > > Thanks!
> > > >
> > > > Well, most importantly patch 5/5 fixes a long-standing bug where we held
> > > > the BKL in lots of places that were already proven not to need it, or
> > > > alternatively held it twice (nested) in the ioctls that may still need it.
> > > >
> > > > I did patch 3/5 this way because I read that you were working on BKL
> > > > removal for TTY and wanted to do my share by removing the dependency
> > > > on the code that I care about (fs/compat_ioctl.h).
> > > >
> > > > Arnd <><
> > >
> > > Thanks!
> > >
> > > I guess these patches could fit in the tty tree, unless someone has
> > > objections?
> >
> > I've taken this patch, I didn't see any others sent to me :(
> >
> > thanks,
> >
> > greg k-h
>
>
> Hmm, several subsystems are involved in this patchset.
> But another one is concerned by the tty tree:
>
> [PATCH 2/5] s390: move keyboard compat ioctls into tty3270 driver
>
> But this whole patchset seems broken if it gets disseminated in several
> trees.
> May be the whole patchset can go in yours?

sure, someone want to send them all to me after getting the other
subsystem's acks?

thanks,

greg k-h