public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Greg KH <gregkh@suse.de>
Cc: Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	Andi Kleen <andi@firstfloor.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH 3/5] tty: handle VT specific compat ioctls in vt driver
Date: Sat, 8 Aug 2009 03:03:36 +0200	[thread overview]
Message-ID: <20090808010336.GN4999@nowhere> (raw)
In-Reply-To: <20090808004156.GA23747@suse.de>

On Fri, Aug 07, 2009 at 05:41:56PM -0700, Greg KH wrote:
> On Sat, Aug 08, 2009 at 02:34:53AM +0200, Frederic Weisbecker wrote:
> > On Fri, Aug 07, 2009 at 02:02:11PM +0200, Arnd Bergmann wrote:
> > > On Friday 07 August 2009, Frederic Weisbecker wrote:
> > > > Ok. This looks like a nice series. A bkl pushdown that only goes down
> > > > in one site among several others enlightens the understanding of what it
> > > > is protecting (beside the nice fact it also burned three bkl callsites :-)
> > > 
> > > Thanks!
> > > 
> > > Well, most importantly patch 5/5 fixes a long-standing bug where we held
> > > the BKL in lots of places that were already proven not to need it, or
> > > alternatively held it twice (nested) in the ioctls that may still need it.
> > > 
> > > I did patch 3/5 this way because I read that you were working on BKL
> > > removal for TTY and wanted to do my share by removing the dependency
> > > on the code that I care about (fs/compat_ioctl.h).
> > > 
> > > 	Arnd <><
> > 
> > Thanks!
> > 
> > I guess these patches could fit in the tty tree, unless someone has
> > objections?
> 
> I've taken this patch, I didn't see any others sent to me :(
> 
> thanks,
> 
> greg k-h


Hmm, several subsystems are involved in this patchset.
But another one is concerned by the tty tree:

[PATCH 2/5] s390: move keyboard compat ioctls into tty3270 driver

But this whole patchset seems broken if it gets disseminated in several
trees.
May be the whole patchset can go in yours?


  reply	other threads:[~2009-08-08  1:03 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-06 13:09 [PATCH 0/5] Kill the BKL in compat ioctl handling Arnd Bergmann
2009-08-06 13:09 ` [PATCH 1/5] arch/um: handle compat_ioctl in tty line driver Arnd Bergmann
2009-08-13  5:08   ` Amerigo Wang
2009-08-06 13:09 ` [PATCH 2/5] s390: move keyboard compat ioctls into tty3270 driver Arnd Bergmann
2009-08-06 13:09 ` [PATCH 3/5] tty: handle VT specific compat ioctls in vt driver Arnd Bergmann
2009-08-07  6:23   ` Frederic Weisbecker
2009-08-07  7:04     ` Arnd Bergmann
2009-08-07  8:04       ` Frederic Weisbecker
2009-08-07 12:02         ` Arnd Bergmann
2009-08-08  0:34           ` Frederic Weisbecker
2009-08-08  0:41             ` Greg KH
2009-08-08  1:03               ` Frederic Weisbecker [this message]
2009-08-08  3:20                 ` Greg KH
2009-08-10 16:24                   ` Arnd Bergmann
2009-08-07  9:57     ` Alan Cox
2009-08-07 19:23       ` Frederic Weisbecker
2009-08-06 13:09 ` [PATCH 4/5] compat_ioctl: remove VT specific ioctl handlers Arnd Bergmann
2009-08-06 13:09 ` [PATCH 5/5] compat_ioctl: do not hold BKL in handlers Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090808010336.GN4999@nowhere \
    --to=fweisbec@gmail.com \
    --cc=andi@firstfloor.org \
    --cc=arnd@arndb.de \
    --cc=gregkh@suse.de \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox