From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933229AbZHHDl4 (ORCPT ); Fri, 7 Aug 2009 23:41:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933002AbZHHDl4 (ORCPT ); Fri, 7 Aug 2009 23:41:56 -0400 Received: from cantor2.suse.de ([195.135.220.15]:35465 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932979AbZHHDlz (ORCPT ); Fri, 7 Aug 2009 23:41:55 -0400 Date: Fri, 7 Aug 2009 20:20:58 -0700 From: Greg KH To: Frederic Weisbecker Cc: Arnd Bergmann , linux-kernel@vger.kernel.org, Christoph Hellwig , Andi Kleen , Alexander Viro Subject: Re: [PATCH 3/5] tty: handle VT specific compat ioctls in vt driver Message-ID: <20090808032058.GA30378@suse.de> References: <1249564170-18627-1-git-send-email-arnd@arndb.de> <200908070904.11260.arnd@arndb.de> <20090807080428.GB4955@nowhere> <200908071402.11217.arnd@arndb.de> <20090808003451.GK4999@nowhere> <20090808004156.GA23747@suse.de> <20090808010336.GN4999@nowhere> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090808010336.GN4999@nowhere> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 08, 2009 at 03:03:36AM +0200, Frederic Weisbecker wrote: > On Fri, Aug 07, 2009 at 05:41:56PM -0700, Greg KH wrote: > > On Sat, Aug 08, 2009 at 02:34:53AM +0200, Frederic Weisbecker wrote: > > > On Fri, Aug 07, 2009 at 02:02:11PM +0200, Arnd Bergmann wrote: > > > > On Friday 07 August 2009, Frederic Weisbecker wrote: > > > > > Ok. This looks like a nice series. A bkl pushdown that only goes down > > > > > in one site among several others enlightens the understanding of what it > > > > > is protecting (beside the nice fact it also burned three bkl callsites :-) > > > > > > > > Thanks! > > > > > > > > Well, most importantly patch 5/5 fixes a long-standing bug where we held > > > > the BKL in lots of places that were already proven not to need it, or > > > > alternatively held it twice (nested) in the ioctls that may still need it. > > > > > > > > I did patch 3/5 this way because I read that you were working on BKL > > > > removal for TTY and wanted to do my share by removing the dependency > > > > on the code that I care about (fs/compat_ioctl.h). > > > > > > > > Arnd <>< > > > > > > Thanks! > > > > > > I guess these patches could fit in the tty tree, unless someone has > > > objections? > > > > I've taken this patch, I didn't see any others sent to me :( > > > > thanks, > > > > greg k-h > > > Hmm, several subsystems are involved in this patchset. > But another one is concerned by the tty tree: > > [PATCH 2/5] s390: move keyboard compat ioctls into tty3270 driver > > But this whole patchset seems broken if it gets disseminated in several > trees. > May be the whole patchset can go in yours? sure, someone want to send them all to me after getting the other subsystem's acks? thanks, greg k-h