From: Josh Triplett <josh@joshtriplett.org>
To: "H. Peter Anvin" <hpa@kernel.org>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] x86: Simplify calls to cpuid by using + for in/out constraints
Date: Sun, 9 Aug 2009 11:34:43 -0700 [thread overview]
Message-ID: <20090809183443.GA24130@feather> (raw)
In-Reply-To: <4A7F0511.6060408@kernel.org>
On Sun, Aug 09, 2009 at 10:19:13AM -0700, H. Peter Anvin wrote:
> I would prefer to not apply this patch unless there is a good reason.
> The existing code isn't broken, and any time we change an asm()
> statement we risk triggering bugs in some obscure gcc version.
Fair enough.
> It isn't, of course, that the proposed change is wrong, but simply that
> it is an unnecessary change, and since it involves asm() statements I
> would like to reject it for churn reduction reasons. Especially so
> since it is "build-tested only".
Given the risk of "bugs in some obscure gcc version", it doesn't seem
like running it or even comparing for identical code would validate
anything more than the correctness of the gcc version currently in use.
- Josh triplett
prev parent reply other threads:[~2009-08-09 19:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-08 20:21 [PATCH] x86: Simplify calls to cpuid by using + for in/out constraints Josh Triplett
2009-08-09 17:19 ` H. Peter Anvin
2009-08-09 18:34 ` Josh Triplett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090809183443.GA24130@feather \
--to=josh@joshtriplett.org \
--cc=akpm@linux-foundation.org \
--cc=hpa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox